Description
Olli-Antti Kivilahti
2015-07-29 12:19:44 UTC
Created attachment 41223 [details] [review] Bug 14616 - Introducing Koha::Object subclasses Just adding the working subclasses as a convenience. Olli, please take a look at the Koha::Object(s) introduced by bug 13851, that is about to be pushed. Olli, please check my message :-D Created attachment 41252 [details] [review] Bug 14616 - Introducing Koha::Object subclasses Created attachment 41532 [details] [review] Bug 14616 - Introducing Koha::Object subclasses Created attachment 42110 [details] [review] Bug 14616 - Koha::Object subclasses Created attachment 42117 [details] [review] Bug 14616 - Squashable Created attachment 44321 [details] [review] Bug 14616 - Introducing Koha::Object subclasses. Fixed Biblioitems result source naming typo. Created attachment 44406 [details] [review] Bug 14616 - Introducing Koha::Object subclasses. Fixed Biblioitems result source naming typo. Comment on attachment 41532 [details] [review] Bug 14616 - Introducing Koha::Object subclasses Review of attachment 41532 [details] [review]: ----------------------------------------------------------------- ::: Koha/Biblio.pm @@ -44,5 @@ > } > > -=head1 AUTHOR > - > -Kyle M Hall <kyle@bywatersolutions.com> Why is this being removed? I don't think Biblio.pm shouldn't even be in this patch. ::: Koha/Biblios.pm @@ +1,3 @@ > package Koha::Biblios; > > +# Copyright Open Source Freedom Fighters This is an addition, not a replacement! @@ +36,5 @@ > } > > +sub _get_castable_unique_columns { > + return ['biblionumber']; > +} This is an addition, which is fine. @@ -55,5 @@ > > -=head1 AUTHOR > - > -Kyle M Hall <kyle@bywatersolutions.com> > - Again, why is this removed? ::: Koha/Item.pm @@ +1,4 @@ > package Koha::Item; > > # Copyright ByWater Solutions 2014 > +# Copyright Open Source Freedom Fighters Why add a copyright for nothing added? ::: Koha/Items.pm @@ +61,5 @@ > =cut > > +sub _get_castable_unique_columns { > + return ['itemnumber', 'barcode']; > +} Like this! Nice, sharing credit, with a functionality addition. I am closing this, Koha::Object[s] subclasses are added as needed during development. Feel free to reopen and attach new patch if you think it is needed. |