Bug 14616 - Introducing Koha::Object subclasses
Summary: Introducing Koha::Object subclasses
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Olli-Antti Kivilahti
QA Contact: Testopia
URL:
Keywords:
Depends on: 13019 13851
Blocks: 13906
  Show dependency treegraph
 
Reported: 2015-07-29 12:19 UTC by Olli-Antti Kivilahti
Modified: 2020-01-06 20:15 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 14616 - Introducing Koha::Object subclasses (12.34 KB, patch)
2015-07-29 12:20 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review
Bug 14616 - Introducing Koha::Object subclasses (12.34 KB, patch)
2015-07-31 10:33 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review
Bug 14616 - Introducing Koha::Object subclasses (28.91 KB, patch)
2015-08-17 12:00 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review
Bug 14616 - Koha::Object subclasses (676 bytes, patch)
2015-08-31 11:04 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review
Bug 14616 - Squashable (5.65 KB, patch)
2015-08-31 12:45 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review
Bug 14616 - Introducing Koha::Object subclasses. Fixed Biblioitems result source naming typo. (969 bytes, patch)
2015-11-03 09:16 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review
Bug 14616 - Introducing Koha::Object subclasses. Fixed Biblioitems result source naming typo. (969 bytes, patch)
2015-11-04 15:16 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Olli-Antti Kivilahti 2015-07-29 12:19:44 UTC
We are using Koha::Object but there are very few subclasses for it.
Here are some!
And hopefully somebody else will add some more!
Comment 1 Olli-Antti Kivilahti 2015-07-29 12:20:29 UTC Comment hidden (obsolete)
Comment 2 Tomás Cohen Arazi 2015-07-29 15:04:01 UTC
Olli, please take a look at the Koha::Object(s) introduced by bug 13851, that is about to be pushed.
Comment 3 Tomás Cohen Arazi 2015-07-30 13:47:52 UTC
Olli, please check my message :-D
Comment 4 Olli-Antti Kivilahti 2015-07-31 10:33:20 UTC Comment hidden (obsolete)
Comment 5 Olli-Antti Kivilahti 2015-08-17 12:00:07 UTC
Created attachment 41532 [details] [review]
Bug 14616 - Introducing Koha::Object subclasses
Comment 6 Olli-Antti Kivilahti 2015-08-31 11:04:34 UTC
Created attachment 42110 [details] [review]
Bug 14616 - Koha::Object subclasses
Comment 7 Olli-Antti Kivilahti 2015-08-31 12:45:17 UTC
Created attachment 42117 [details] [review]
Bug 14616 - Squashable
Comment 8 Olli-Antti Kivilahti 2015-11-03 09:16:32 UTC Comment hidden (obsolete)
Comment 9 Olli-Antti Kivilahti 2015-11-04 15:16:30 UTC
Created attachment 44406 [details] [review]
Bug 14616 - Introducing Koha::Object subclasses. Fixed Biblioitems result source naming typo.
Comment 10 Mark Tompsett 2016-02-17 16:45:51 UTC
Comment on attachment 41532 [details] [review]
Bug 14616 - Introducing Koha::Object subclasses

Review of attachment 41532 [details] [review]:
-----------------------------------------------------------------

::: Koha/Biblio.pm
@@ -44,5 @@
>  }
>  
> -=head1 AUTHOR
> -
> -Kyle M Hall <kyle@bywatersolutions.com>

Why is this being removed? I don't think Biblio.pm shouldn't even be in this patch.

::: Koha/Biblios.pm
@@ +1,3 @@
>  package Koha::Biblios;
>  
> +# Copyright Open Source Freedom Fighters

This is an addition, not a replacement!

@@ +36,5 @@
>  }
>  
> +sub _get_castable_unique_columns {
> +    return ['biblionumber'];
> +}

This is an addition, which is fine.

@@ -55,5 @@
>  
> -=head1 AUTHOR
> -
> -Kyle M Hall <kyle@bywatersolutions.com>
> -

Again, why is this removed?

::: Koha/Item.pm
@@ +1,4 @@
>  package Koha::Item;
>  
>  # Copyright ByWater Solutions 2014
> +# Copyright Open Source Freedom Fighters

Why add a copyright for nothing added?

::: Koha/Items.pm
@@ +61,5 @@
>  =cut
>  
> +sub _get_castable_unique_columns {
> +    return ['itemnumber', 'barcode'];
> +}

Like this! Nice, sharing credit, with a functionality addition.
Comment 11 Josef Moravec 2019-02-26 07:21:14 UTC
I am closing this, Koha::Object[s] subclasses are added as needed during development.

Feel free to reopen and attach new patch if you think it is needed.