Summary: | adds fixed_fines for overdues | ||
---|---|---|---|
Product: | Koha | Reporter: | delaye <stephane.delaye> |
Component: | Notices | Assignee: | Bugs List <koha-bugs> |
Status: | In Discussion --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | andreas.hedstrom.mace, charles.farmer, fridolin.somers, jens.weber, jonathan.druart, victor |
Version: | Main | Keywords: | dependency |
Hardware: | All | ||
OS: | All | ||
See Also: |
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12770 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13816 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 |
||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 14666 - add fixed_fines for overdues
Bug 14666 - add fixed_fines for overdues |
Description
delaye
2015-08-10 08:29:35 UTC
Hi Stephane, I am in doubt about this patch - especially the new dependencies. What are they used for? We have a new plugin to format prices now and also some existing code to do that - could it be achieved with the existing modules? I also think this would be good on separate bugs - for example the colums added to the CSV seem unrelated to the main feature. (In reply to Katrin Fischer from comment #1) > Hi Stephane, > > I am in doubt about this patch - especially the new dependencies. What are > they used for? We have a new plugin to format prices now and also some > existing code to do that - could it be achieved with the existing modules? Ok thanks for the information. > > I also think this would be good on separate bugs - for example the colums > added to the CSV seem unrelated to the main feature. Indeed, this bug will only focus on adding fixed_fines to overdue notices. Created attachment 43116 [details] [review] Bug 14666 - add fixed_fines for overdues - Add a overduerules.fixed_fineX for the 3 levels - Add a column "Fixed fines" in the tools/overduerules.pl page Hi Fridolin, Could you take a look at Bug 12769? The patch was developed in 2014 to address the issue of adding a fee to any kind of notice, including overdue notices, and from what I see, your needs could be covered by that patch. If we want to see this feature added to Koha someday, we will have to join our efforts. (In reply to Charles Farmer from comment #4) > Hi Fridolin, > > Could you take a look at Bug 12769? Nope, thanks for this (In reply to Fridolin SOMERS from comment #5) > (In reply to Charles Farmer from comment #4) > > Hi Fridolin, > > > > Could you take a look at Bug 12769? > Nope, thanks for this Sorry I thought you said "Did you have a look at Bug 12769?" :D So my real answer : Yes, I'll have a look when I can find time. (In reply to Fridolin SOMERS from comment #6) Thank you for clearing this up ;) Patch doesn't apply at the moment: CONFLICT (content): Merge conflict in tools/overduerules.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql The code looks clean, but appears to contain only the CRUD for the GUI, not the actually charging of the fine yet. Created attachment 76063 [details] [review] Bug 14666 - add fixed_fines for overdues - Add a overduerules.fixed_fineX for the 3 levels - Add a column "Fixed fines" in the tools/overduerules.pl page Rebased and compared the old and new patches to check that nothing was lost or added. The bug title is not very descrpitive, maybe fix in order to lure testers in? Should this still be "In discussion" or NSO? There doesn't seems to be any pending points right? Wait, maybe comment 4 is still valid? Or should we move on independently of bug 12769 that might be to wide to manage to make it through? (and which is also in discussion) > The bug title is not very descrpitive, maybe fix in order to lure testers in?
"Add fees when overdue notices triggers" ? I'm not sure to understand well enough to be sure if that's the aim.
(In reply to Victor Grousset/tuxayo from comment #12) > There doesn't seems to be any pending points right? This is a very old fashioned way of doing it (I know I wrote that code years ago), but it works. IIRC the main problem was to make it consistent with bug 12769. Needs rebase since Bug 19817 |