Bug 14775

Summary: Plack::Middleware::ReverseProxy should not be required
Product: Koha Reporter: Jonathan Druart <jonathan.druart+koha>
Component: Architecture, internals, and plumbingAssignee: Galen Charlton <gmcharlt>
Status: CLOSED WORKSFORME QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: tomascohen
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 13791    
Bug Blocks:    
Attachments: Bug 14775: Plack::Middleware::ReverseProxy should not be required
Bug 14775: Plack::Middleware::ReverseProxy should not be required
[PASSED QA] Bug 14775: Plack::Middleware::ReverseProxy should not be required

Description Jonathan Druart 2015-09-03 09:12:46 UTC

    
Comment 1 Jonathan Druart 2015-09-03 09:13:30 UTC Comment hidden (obsolete)
Comment 2 Marcel de Rooy 2015-09-03 09:15:40 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2015-09-03 21:48:40 UTC
Created attachment 42363 [details] [review]
[PASSED QA] Bug 14775: Plack::Middleware::ReverseProxy should not be required

But optional.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2015-09-04 02:25:55 UTC
I think this patch breaks a functionality without a clear reason. Maybe I'm missing something else, as it is shipped in all supported platforms. In case we move on with this, we need a follow-up for koha-plack checking the absence of the lib. And probably patching plack.psgi so it works without it.
But I repeat, I'm not sure why we need this.