Summary: | Plack::Middleware::ReverseProxy should not be required | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Galen Charlton <gmcharlt> |
Status: | CLOSED WORKSFORME | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 13791 | ||
Bug Blocks: | |||
Attachments: |
Bug 14775: Plack::Middleware::ReverseProxy should not be required
Bug 14775: Plack::Middleware::ReverseProxy should not be required [PASSED QA] Bug 14775: Plack::Middleware::ReverseProxy should not be required |
Description
Jonathan Druart
2015-09-03 09:12:46 UTC
Created attachment 42277 [details] [review] Bug 14775: Plack::Middleware::ReverseProxy should not be required But optional. Created attachment 42278 [details] [review] Bug 14775: Plack::Middleware::ReverseProxy should not be required But optional. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 42363 [details] [review] [PASSED QA] Bug 14775: Plack::Middleware::ReverseProxy should not be required But optional. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> I think this patch breaks a functionality without a clear reason. Maybe I'm missing something else, as it is shipped in all supported platforms. In case we move on with this, we need a follow-up for koha-plack checking the absence of the lib. And probably patching plack.psgi so it works without it. But I repeat, I'm not sure why we need this. |