Bug 14775 - Plack::Middleware::ReverseProxy should not be required
Summary: Plack::Middleware::ReverseProxy should not be required
Status: CLOSED WORKSFORME
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Galen Charlton
QA Contact: Testopia
URL:
Keywords:
Depends on: 13791
Blocks:
  Show dependency treegraph
 
Reported: 2015-09-03 09:12 UTC by Jonathan Druart
Modified: 2016-06-21 21:37 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 14775: Plack::Middleware::ReverseProxy should not be required (805 bytes, patch)
2015-09-03 09:13 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 14775: Plack::Middleware::ReverseProxy should not be required (909 bytes, patch)
2015-09-03 09:15 UTC, Marcel de Rooy
Details | Diff | Splinter Review
[PASSED QA] Bug 14775: Plack::Middleware::ReverseProxy should not be required (933 bytes, patch)
2015-09-03 21:48 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2015-09-03 09:12:46 UTC

    
Comment 1 Jonathan Druart 2015-09-03 09:13:30 UTC Comment hidden (obsolete)
Comment 2 Marcel de Rooy 2015-09-03 09:15:40 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2015-09-03 21:48:40 UTC
Created attachment 42363 [details] [review]
[PASSED QA] Bug 14775: Plack::Middleware::ReverseProxy should not be required

But optional.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2015-09-04 02:25:55 UTC
I think this patch breaks a functionality without a clear reason. Maybe I'm missing something else, as it is shipped in all supported platforms. In case we move on with this, we need a follow-up for koha-plack checking the absence of the lib. And probably patching plack.psgi so it works without it.
But I repeat, I'm not sure why we need this.