Bug 14792

Summary: Fix visibility check for 'place holds' link in OPAC result list
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: Hold requestsAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: aleisha, gmcharlt, hc, jzairo, kelly, marjorie.barry-vila, patrick.robitaille, srdjan, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 5786    
Bug Blocks:    

Description Katrin Fischer 2015-09-07 21:20:15 UTC
The 'place hold' link shows, even when no items are holdable. 
This is a side effect of the changes from 5786 and should be fixed.
Comment 1 Katrin Fischer 2016-02-29 23:24:43 UTC
*** Bug 15944 has been marked as a duplicate of this bug. ***
Comment 2 Aleisha Amohia 2016-04-29 03:27:40 UTC
Can you please check if this is still valid? It appears to have been fixed in the latest version
Comment 3 Marjorie Barry-Vila 2020-01-15 20:54:23 UTC
Hi,

Link "Place hold" do not appear in OPAC result list according to the parameters chosen in the circulation rules in the "On shelf holds allowed" column.

I am testing on version 19.05:

- If any unavailable : link do not appears
- If all unavailable : link appears
- Yes : link appears

For exemple, with "If any unavailable", if i have 2 items on a notice and one of them is checked out, "Place hold" link should appear in the result list.

It's the same if it's a notice with a single item.  



Regards,

Marjorie
Comment 4 Holly 2021-02-02 14:53:38 UTC
I'm seeing something that might relate to this, thought I'd add it in. A site is only allowing holds on records where all items have been checked out, so "On shelf holds allowed" is set to "If all unavailable" across the board. However, the "Place hold" link is appearing on the OPAC for records with items on the shelf.

When the "Place hold" link is used to actually place a hold, a message appears informing the patron that none of the items on the record can be placed on hold, which is correct behaviour. I've had feedback that it is frustrating for logged in patrons to see a "Place hold" link and staff find it odd that a link would appear when there isn't any circumstances, as the circulation rules are set, where a hold would be possible.