Summary: | Batch record modification tool removes framework code | ||
---|---|---|---|
Product: | Koha | Reporter: | Pablo AB <pablo.bianchi> |
Component: | Tools | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | critical | ||
Priority: | P5 - low | CC: | chris, f.demians, jonathan.druart, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 11395 | ||
Bug Blocks: | |||
Attachments: |
Bug 14795: Prevent modifying a record without using the original framework
[SIGNED-OFF] Bug 14795: Prevent modifying a record without using the original framework [PASSED QA] Bug 14795: Prevent modifying a record without using the original framework |
Description
Pablo AB
2015-09-08 13:09:21 UTC
This a major one and blocker for the 3.22 release. Actually it's in 3.20.x already, so raising again the severity. Lost of data possible! Ccing Chris as 3.20.x RM Created attachment 44849 [details] [review] Bug 14795: Prevent modifying a record without using the original framework The origin framework is not passed on modifying the records and so the default one is used. This can caused data lost. Test plan: - Create a bibliographic record and specify a framework (not the default one). - Use the Batch records modification tools to modify it. => Without this patch, the default framework (framework code "") is used and can deteriorate the record => With this patch, the record is saved using the original framework Created attachment 44856 [details] [review] [SIGNED-OFF] Bug 14795: Prevent modifying a record without using the original framework The origin framework is not passed on modifying the records and so the default one is used. This can caused data lost. Test plan: - Create a bibliographic record and specify a framework (not the default one). - Use the Batch records modification tools to modify it. => Without this patch, the default framework (framework code "") is used and can deteriorate the record => With this patch, the record is saved using the original framework Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested framework is lost using tool without patch Problem gone with patch No qa errors Created attachment 44868 [details] [review] [PASSED QA] Bug 14795: Prevent modifying a record without using the original framework The origin framework is not passed on modifying the records and so the default one is used. This can caused data lost. Test plan: - Create a bibliographic record and specify a framework (not the default one). - Use the Batch records modification tools to modify it. => Without this patch, the default framework (framework code "") is used and can deteriorate the record => With this patch, the record is saved using the original framework Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested framework is lost using tool without patch Problem gone with patch No qa errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patch pushed to master. Thanks Jonathan! This patch has been pushed to 3.20.x, will be in 3.20.6. |