Summary: | Wrong shortcuts in module "cataloging" | ||
---|---|---|---|
Product: | Koha | Reporter: | Michael Kuhn <mik> |
Component: | Cataloging | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | jonathan.druart, liz, m.de.rooy, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14880 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 14829: Fix shortcuts in the cataloging and patron modules
Bug 14829: Fix shortcuts in the cataloging and patron modules [PASSED QA] Bug 14829: Fix shortcuts in the cataloging and patron modules |
Description
Michael Kuhn
2015-09-15 22:50:58 UTC
Created attachment 42570 [details] [review] Bug 14829: Fix shortcuts in the cataloging and patron modules In these 2 modules, the shortcuts alt+q, alt+r and alt+u don't work as in other modules. The tab are not "built" in the correct order and the id returned to select the correct tab is wrong. Test plan: Go on the circ home page (circ/circulation-home.pl), the patron home page (members/members-home.pl) and the cataloging home page (cataloguing/addbooks.pl). On these 3 pages, without this patch, the shortcuts select different tabs. With this patch, the issue is fixed for all of them. I applied the patch manually in the files "cataloging-search.inc" and "patron-search.inc" of directory "/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/de-DE/includes" and the patch works as expected. Created attachment 42585 [details] [review] Bug 14829: Fix shortcuts in the cataloging and patron modules In these 2 modules, the shortcuts alt+q, alt+r and alt+u don't work as in other modules. The tab are not "built" in the correct order and the id returned to select the correct tab is wrong. Test plan: Go on the circ home page (circ/circulation-home.pl), the patron home page (members/members-home.pl) and the cataloging home page (cataloguing/addbooks.pl). On these 3 pages, without this patch, the shortcuts select different tabs. With this patch, the issue is fixed for all of them. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> You might check the serials module tabs as well. :) (In reply to Liz Rea from comment #4) > You might check the serials module tabs as well. :) Yes, it looks good. But, even without this patch :) Why did you say that? Because when I was looking at it the other day, it seemed like it was acting weirdly, but I take your word for it that it's ok. :) Created attachment 42981 [details] [review] [PASSED QA] Bug 14829: Fix shortcuts in the cataloging and patron modules In these 2 modules, the shortcuts alt+q, alt+r and alt+u don't work as in other modules. The tab are not "built" in the correct order and the id returned to select the correct tab is wrong. Test plan: Go on the circ home page (circ/circulation-home.pl), the patron home page (members/members-home.pl) and the cataloging home page (cataloguing/addbooks.pl). On these 3 pages, without this patch, the shortcuts select different tabs. With this patch, the issue is fixed for all of them. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patch pushed to master. Thanks Jonathan! |