Bug 14830

this patch adds some SQL to display suggestion rows with a NULL branchcode, in the staff interface

Created attachment 43245 [details]
pix, after patch

Created attachment 43246 [details] [review]
Bug 14830 - anonymous purchase suggestions are invisible/inaccessible in staff interface

To test bug...

1/ set various suggestion sysprefs like so

mysql> select variable, value  from systempreferences where variable like '%sugg%';
+-------------------------------------+-------+
| variable                            | value |
+-------------------------------------+-------+
| AllowPurchaseSuggestionBranchChoice | 0     |
| AnonSuggestions                     | 1     |
| OpacSuggestionManagedBy             | 1     |
| OPACViewOthersSuggestions           | 0     |
| suggestion                          | 1     |
+-------------------------------------+-------+

2/ create an generic ANON borrower for testing

3/ set 'AnonymousPatron' syspref to ANON's borrowernumber

4/ add a suggestion from the OPAC, without being logged in (ie: an anonymous suggestion)

5/ go to staff interface , fail to see suggestion :'(
    https://demo-admin.yourkoha.foo/cgi-bin/koha/suggestion/suggestion.pl

6/ apply patch...

7/ go to staff interface , see suggestion! :) (pix attached)
    https://demo-admin.yourkoha.foo/cgi-bin/koha/suggestion/suggestion.pl

8/ reward yourself with cake (optional)

Testing:

- Check with mysql: I did not have branchcode = NULL in the suggestions table.
- I tried to have one by removing syspref AnonymousPatron and then submit a
suggestion from OPAC, it resulted in an software error on Suggestions.pm line 108 (Column 'suggestedby' canot be null). 
- I set the branchcode of one of the suggestions to NULL usimg mysql
- I could reproduce the issue (the one with NULL branchcode did not show up)
- With patch, the NULL-suggestion shows up, that is OK so far.


More testing:
- In the mysgl table I have following branchcodes: FFL, FFL, FFL, MPL, NULL, all with status ASKED

- On the home page, I have "Suggestions pending approval: 5" 

- But not all suggestions show up when managing suggestions, only the ones with the same branchcode as the staff user (branch code FFL, all rights set, superlibrarian), plus the NULL one if the patch is applied.

That is not consistent. 

The question is:
Should the librarian be able to manage the suggestions for all branches?

- If yes, all sggestions should display on Home > Acquisitions > Suggestions management (I think including the NULL branchcode ones). 
  I would expect that for IndependentBranches = 'Don't prevent...' and superlibrarians. (That's the behaviour of this syspref for other things).

- If no, the counter on the home page needs some adjustement to show the count of pending suggestions that are manageable for the staff users branch
  I would expect that for IndependentBranches = 'Don't prevent...' current staff user is not a superlibrarian.

One more finding: A suggestion ist not visible / manageable if created in staff client with Library set to "Any"

The value for the library code in the database is en empty string in that case. It is not visible in staff client, not even for superlibrarians (with and without patch).

Still valid.


Marjorie

This is not quite true, you can view these suggestions, they just don't show up by default.

If you click on 'Acquisition Information' on the left side of the screen it expands into filters for 'Book fund' and 'Library'

Set 'Library' to 'Any' and these suggestions should show

This is definitely not intuitive and should be addressed, perhaps if we indicate on the screen somewhere that we are already filtering by branch?

*** This bug has been marked as a duplicate of bug 24073 ***

Marked duplicate with a newer bug about this issue/topic - I think it's a recurring problem but with indybranches etc not trivial to solve in a good way.