Bug 14839 - 'anonymous' purchase suggestions are created with 'Anon' user's branchcode ignored, (NULL branchcode)
Summary: 'anonymous' purchase suggestions are created with 'Anon' user's branchcode ig...
Status: In Discussion
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Mason James
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 14830
  Show dependency treegraph
 
Reported: 2015-09-17 03:38 UTC by Mason James
Modified: 2017-11-08 13:58 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mason James 2015-09-17 03:38:52 UTC
if an anonymous purchase suggestion is created from the OPAC, it's branchcode is NULL,
despite the 'Anon' user having a valid branchcode

this bug makes any 'Anon' suggestion invisible in the staff interface

more info to come...
Comment 1 Katrin Fischer 2015-09-17 05:58:23 UTC
I don't think we should be using the Anon user's branchcode - we only have one AnonymousPatron account, even for very big systems with multiple branches. Using an empty branchcode would be better and make that show up correctly again in the interface. It used to be a string - I think __ANY__ or similar, but there was a patch that changed it to be empty, which makes more sense, but might have missed something.
Comment 2 Jonathan Druart 2015-09-17 06:49:15 UTC
Mason,
If you plan to work on it, please assign you the bug.
Comment 3 Mason James 2015-09-22 03:18:55 UTC
(In reply to Katrin Fischer from comment #1)
> I don't think we should be using the Anon user's branchcode - we only have
> one AnonymousPatron account, even for very big systems with multiple
> branches. Using an empty branchcode would be better and make that show up
> correctly again in the interface. It used to be a string - I think __ANY__
> or similar, but there was a patch that changed it to be empty, which makes
> more sense, but might have missed something.

hiya, yes - I do agree with you Cait :0)

I think a better fix would be to modify the staff suggestions page, to display all NULL suggestions

^ i do have a small SQL patch for this, that i'll attach
Comment 4 Mason James 2015-09-22 03:19:53 UTC
(In reply to Jonathan Druart from comment #2)
> Mason,
> If you plan to work on it, please assign you the bug.

yes, will do
Comment 5 Mason James 2015-10-08 09:51:00 UTC
(In reply to Mason James from comment #4)
> (In reply to Jonathan Druart from comment #2)
> > Mason,
> > If you plan to work on it, please assign you the bug.
> 
> yes, will do

i've attached my patch to BZ 14830