|Summary:||Upgrade jQuery from 1.7 to 3.4.1 in OPAC|
|Product:||Koha||Reporter:||Mason James <mtj>|
|Component:||OPAC||Assignee:||Owen Leonard <oleonard>|
|Status:||RESOLVED FIXED||QA Contact:||Testopia <testopia>|
|Priority:||P5 - low||CC:||dcook, katrin.fischer, lucas, martin.renvoize|
|Change sponsored?:||---||Patch complexity:||Small patch|
|Text to go in the release notes:||Version(s) released in:||
|Bug Depends on:|
|Bug Blocks:||20168, 25793, 25038, 25597|
|Attachments:||Bug 14862: (follow-up) Add minified version of jQuery 3.4.1|
Description Mason James 2015-09-21 09:34:20 UTC
This change is needed to allow bug 10659 to progress http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659
Comment 1 Owen Leonard 2019-08-16 15:03:06 UTC
This is ready for testing, bug Bugzilla rejects the patches because of the size. I've posted the branch here: https://gitlab.com/koha-dev/koha-dev/tree/bug-14862-opac-jquery-upgrade I have also put a downloadable patch here in case that helps: https://zivotdesign.com/download/bug-14862.patch
Comment 2 Lucas Gass 2019-08-16 20:43:05 UTC
Is there any test plan for this?
Comment 3 Owen Leonard 2019-08-18 22:25:41 UTC
Comment 4 Martin Renvoize 2019-10-02 22:35:21 UTC
I've checked out the branch (and rebased it to check it still applies simply). All seems to work well, no obvious regressions.. signing off.
Comment 5 Katrin Fischer 2019-10-03 08:24:45 UTC
Ready to pass QA from testing - Pages all look good and behave well for me. Just one thing: Although the file has the .min. in the name, it's not actually minified. Can you please check and follow-up? If you want, you can already add my sign-off line :)
Comment 6 Owen Leonard 2019-10-07 14:02:06 UTC
Created attachment 93823 [details] [review] Bug 14862: (follow-up) Add minified version of jQuery 3.4.1 This patch updates the file 'jquery-3.4.1.min.js' so that it is indeed minified.
Comment 7 Katrin Fischer 2019-10-07 14:43:07 UTC
Asking the RM to take care of the Sign-off lines, please!
Comment 8 Martin Renvoize 2019-10-07 15:21:46 UTC
Nice work! Pushed to master for 19.11.00