| Summary: | userid not generated when defined in BorrowerUnwantedField | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
| Component: | Patrons | Assignee: | Fridolin Somers <fridolin.somers> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | f.demians, gmcharlt, kyle.m.hall, liz, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20367 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 14867 - userid not generated when defined in BorrowerUnwantedField
Bug 14867 - userid not generated when defined in BorrowerUnwantedField Bug 14867 - userid not generated when defined in BorrowerUnwantedField [PASSED QA] Bug 14867 - userid not generated when defined in BorrowerUnwantedField |
||
|
Description
Fridolin Somers
2015-09-22 07:54:42 UTC
Created attachment 42753 [details] [review] Bug 14867 - userid not generated when defined in BorrowerUnwantedField When userid is not provided when creating a new patron, it is generated using surname and firstname. The bug is when userid is defined in syspref BorrowerUnwantedField, the input text is missing in patron creation form. When saving you always get an alert message : "Username/password already exists". No patron can be created. This patch corrects by adding this case to userid generation conditions. Test plan : - add 'userid' in syspref BorrowerUnwantedField - try to create a new patron : /cgi-bin/koha/members/memberentry.pl - there is not input text for userid - choose non-existing surname and firstname - click on save => Without patch : patron is not created, you see the alert message "Username/password already exists" => With patch : patron is created, userid is generated with surname and firstname - remove 'userid' in syspref BorrowerUnwantedField and check it can be defined in patron creation form Created attachment 42755 [details] [review] Bug 14867 - userid not generated when defined in BorrowerUnwantedField When userid is not provided when creating a new patron, it is generated using surname and firstname. The bug is when userid is defined in syspref BorrowerUnwantedField, the input text is missing in patron creation form. When saving you always get an alert message : "Username/password already exists". No patron can be created. This patch corrects by adding this case to userid generation conditions. Test plan : - add 'userid' in syspref BorrowerUnwantedField - try to create a new patron : /cgi-bin/koha/members/memberentry.pl - there is not input text for userid - choose non-existing surname and firstname - click on save => Without patch : patron is not created, you see the alert message "Username/password already exists" => With patch : patron is created, userid is generated with surname and firstname - remove 'userid' in syspref BorrowerUnwantedField and check it can be defined in patron creation form Created attachment 44314 [details] [review] Bug 14867 - userid not generated when defined in BorrowerUnwantedField When userid is not provided when creating a new patron, it is generated using surname and firstname. The bug is when userid is defined in syspref BorrowerUnwantedField, the input text is missing in patron creation form. When saving you always get an alert message : "Username/password already exists". No patron can be created. This patch corrects by adding this case to userid generation conditions. Test plan : - add 'userid' in syspref BorrowerUnwantedField - try to create a new patron : /cgi-bin/koha/members/memberentry.pl - there is not input text for userid - choose non-existing surname and firstname - click on save => Without patch : patron is not created, you see the alert message "Username/password already exists" => With patch : patron is created, userid is generated with surname and firstname - remove 'userid' in syspref BorrowerUnwantedField and check it can be defined in patron creation form Signed-off-by: Frédéric Demians <f.demians@tamil.fr> The issue is there, and this patch fixes it. Created attachment 44554 [details] [review] [PASSED QA] Bug 14867 - userid not generated when defined in BorrowerUnwantedField When userid is not provided when creating a new patron, it is generated using surname and firstname. The bug is when userid is defined in syspref BorrowerUnwantedField, the input text is missing in patron creation form. When saving you always get an alert message : "Username/password already exists". No patron can be created. This patch corrects by adding this case to userid generation conditions. Test plan : - add 'userid' in syspref BorrowerUnwantedField - try to create a new patron : /cgi-bin/koha/members/memberentry.pl - there is not input text for userid - choose non-existing surname and firstname - click on save => Without patch : patron is not created, you see the alert message "Username/password already exists" => With patch : patron is created, userid is generated with surname and firstname - remove 'userid' in syspref BorrowerUnwantedField and check it can be defined in patron creation form Signed-off-by: Frédéric Demians <f.demians@tamil.fr> The issue is there, and this patch fixes it. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch pushed to master. Thanks Frido! This patch has been pushed to 3.20.x, will be in 3.20.6. Pushed to 3.18.13, and released. |