Description
Joonas Kylmälä
2015-09-25 08:49:18 UTC
Created attachment 42867 [details] [review] Bug 14895: Removes the ability to edit already added item's info from serials-edit.pl page Created attachment 42868 [details] [review] Bug 14895: Removes the ability to edit already added item's info from serials-edit.pl page Notice that this patch is done for 3.16. It might not apply without manual merging to the upstream. Test plan: 1. In serials create a new subscription with the option "create an item record when receiving this serial" selected. You can choose the other properties. 2. Find the newly created serial subscription by using the top bar's search. 3. Click from the 'Actions' drop-down menu 'Serial receive'. 4. Change the status to 'Arrived'. Add something to the barcode field. Save. 4.1 (Optional step) Open a new tab in your browser and go see that there is in the catalogue the item you just added and it has a barcode. 5. Now you should have arrived to the page serials-collection.pl. Here, select the very same serial item you just edited and click 'Edit serials' 6. Now click just save button without doing any changes. 7. Go to find that item from the biblio record. Notice its barcode is missing now. 8. Apply the patch 9. Put there some barcode to the item manually. 9. Go back to the serials-collection.pl page and select the item and click 'Edit serials'. 10. Click save on the edit-serials.pl page without changing any information. 11. Go and check that the item has still its barcode. 12. Find out if this patch's changes to edit-serials.pl has caused some problems in other parts of the system. Looks like the patch applied correctly also to the latest master! :) Created attachment 42869 [details] [review] Bug 14895: Removes the ability to edit already added item's info from serials-edit.pl page Test plan: 1. In serials create a new subscription with the option "create an item record when receiving this serial" selected. You can choose the other properties. 2. Find the newly created serial subscription by using the top bar's search. 3. Click from the 'Actions' drop-down menu 'Serial receive'. 4. Change the status to 'Arrived'. Add something to the barcode field. Save. 4.1 (Optional step) Open a new tab in your browser and go see that there is in the catalogue the item you just added and it has a barcode. 5. Now you should have arrived to the page serials-collection.pl. Here, select the very same serial item you just edited and click 'Edit serials' 6. Now click just save button without doing any changes. 7. Go to find that item from the biblio record. Notice its barcode is missing now. 8. Apply the patch 9. Put there some barcode to the item manually. 9. Go back to the serials-collection.pl page and select the item and click 'Edit serials'. 10. Click save on the edit-serials.pl page without changing any information. 11. Go and check that the item has still its barcode. 12. Find out if this patch's changes to edit-serials.pl has caused some problems in other parts of the system. Created attachment 44937 [details] [review] Bug 14895: Removes the ability to edit already added item's info from serials-edit.pl page Test plan: 1. In serials create a new subscription with the option "create an item record when receiving this serial" selected. You can choose the other properties. 2. Find the newly created serial subscription by using the top bar's search. 3. Click from the 'Actions' drop-down menu 'Serial receive'. 4. Change the status to 'Arrived'. Add something to the barcode field. Save. 4.1 (Optional step) Open a new tab in your browser and go see that there is in the catalogue the item you just added and it has a barcode. 5. Now you should have arrived to the page serials-collection.pl. Here, select the very same serial item you just edited and click 'Edit serials' 6. Now click just save button without doing any changes. 7. Go to find that item from the biblio record. Notice its barcode is missing now. 8. Apply the patch 9. Put there some barcode to the item manually. 9. Go back to the serials-collection.pl page and select the item and click 'Edit serials'. 10. Click save on the edit-serials.pl page without changing any information. 11. Go and check that the item has still its barcode. 12. Find out if this patch's changes to edit-serials.pl has caused some problems in other parts of the system. Signed-off-by: Liz Rea <liz@catalyst.net.nz> This appears similar to bug 15030 - which I think tries to fix the behaviour. Liz, could you maybe take a look at the other bug too? Or Joonas? (In reply to Katrin Fischer from comment #7) > Or Joonas? I'm not working on this bug anymore, so someone else feel free to assign this to him- or herself. Created attachment 45055 [details] [review] Bug 14895: Removes the ability to edit already added item's info from serials-edit.pl page Test plan: 1. In serials create a new subscription with the option "create an item record when receiving this serial" selected. You can choose the other properties. 2. Find the newly created serial subscription by using the top bar's search. 3. Click from the 'Actions' drop-down menu 'Serial receive'. 4. Change the status to 'Arrived'. Add something to the barcode field. Save. 4.1 (Optional step) Open a new tab in your browser and go see that there is in the catalogue the item you just added and it has a barcode. 5. Now you should have arrived to the page serials-collection.pl. Here, select the very same serial item you just edited and click 'Edit serials' 6. Now click just save button without doing any changes. 7. Go to find that item from the biblio record. Notice its barcode is missing now. 8. Apply the patch 9. Put there some barcode to the item manually. 9. Go back to the serials-collection.pl page and select the item and click 'Edit serials'. 10. Click save on the edit-serials.pl page without changing any information. 11. Go and check that the item has still its barcode. 12. Find out if this patch's changes to edit-serials.pl has caused some problems in other parts of the system. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 45056 [details] [review] Bug 14895 [QA Followup] - Fix indentation for readability Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Considering bug 15030 is in active development, we should probably wait to see if that one takes care of this bug. I can't reproduce this one. Could some else test it ? cc Claire as she's a bug wrangler. (In reply to Koha Team Lyon 3 from comment #12) > I can't reproduce this one. Could some else test it ? > cc Claire as she's a bug wrangler. I couldn't reproduce it either. Most likely fixed by 15030 |