Bug 14895 - We shouldn't be able to edit already added serials' items from serial receive/edit page
Summary: We shouldn't be able to edit already added serials' items from serial receive...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-25 08:49 UTC by Joonas Kylmälä
Modified: 2019-10-14 19:57 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 14895: Removes the ability to edit already added item's info from serials-edit.pl page (3.13 KB, patch)
2015-09-25 08:51 UTC, Joonas Kylmälä
Details | Diff | Splinter Review
Bug 14895: Removes the ability to edit already added item's info from serials-edit.pl page (4.32 KB, patch)
2015-09-25 09:01 UTC, Joonas Kylmälä
Details | Diff | Splinter Review
Bug 14895: Removes the ability to edit already added item's info from serials-edit.pl page (4.31 KB, patch)
2015-09-25 09:19 UTC, Joonas Kylmälä
Details | Diff | Splinter Review
Bug 14895: Removes the ability to edit already added item's info from serials-edit.pl page (4.36 KB, patch)
2015-11-18 00:50 UTC, Liz Rea
Details | Diff | Splinter Review
Bug 14895: Removes the ability to edit already added item's info from serials-edit.pl page (4.42 KB, patch)
2015-11-20 14:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 14895 [QA Followup] - Fix indentation for readability (8.54 KB, patch)
2015-11-20 14:56 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Joonas Kylmälä 2015-09-25 08:49:18 UTC
When you receive some serials you go to the serials/serials-edit.pl page. You change there the status to 'Arrived' and add a new item (if it has been chosen so in the subscription creation step). Now if after that someone goes and changes the status to, for example, 'Expected' then the system automatically overrides the item's info which is already in the system. This happens because the serial-edit.pl don't retrieve any information from the items which are already in the system.

Well, I guess nobody will change an arrived item to expected usually, only in the cases when it has been a misclick or something. So the real problem is that if you just go to the serials-edit.pl page and don't change anything, and click save, the existing item will have some of its info deleted (barcode as one example).

I have a patch for this problem (will add soon here). Instead of retrieving the already added items' data I choosed to disable the "ability" to change the already added items' info from serials-edit.pl (one can change item information from cataloguing -> something, if needed).

I guess my explanation is not so clear, so I will provide you the steps how to reproduce this bug:

1. In serials create a new subscription with the option "create an item record when receiving this serial" selected. You can choose the other properties.
2. Find the newly created serial subscription by using the top bar's search.
3. Click from the 'Actions' drop-down menu 'Serial receive'.
4. Change the status to 'Arrived'. Add something to the barcode field. Save.
4.1 (Optional step) Open a new tab in your browser and go see that there is in the catalogue the item you just added and it has a barcode.
5. Now you should have arrived to the page serials-collection.pl. Here, select the very same serial item you just edited and click 'Edit serials' 
6. Now click just save button without doing any changes.
7. Go to find that item from the biblio record. Notice its barcode is missing now.
Comment 1 Joonas Kylmälä 2015-09-25 08:51:16 UTC Comment hidden (obsolete)
Comment 2 Joonas Kylmälä 2015-09-25 09:01:03 UTC Comment hidden (obsolete)
Comment 3 Joonas Kylmälä 2015-09-25 09:02:34 UTC
Looks like the patch applied correctly also to the latest master! :)
Comment 4 Joonas Kylmälä 2015-09-25 09:19:44 UTC Comment hidden (obsolete)
Comment 5 Liz Rea 2015-11-18 00:50:31 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2015-11-18 08:50:00 UTC
This appears similar to bug 15030 - which I think tries to fix the behaviour. Liz, could you maybe take a look at the other bug too?
Comment 7 Katrin Fischer 2015-11-18 08:51:28 UTC
Or Joonas?
Comment 8 Joonas Kylmälä 2015-11-18 09:08:01 UTC
(In reply to Katrin Fischer from comment #7)
> Or Joonas?

I'm not working on this bug anymore, so someone else feel free to assign this to him- or herself.
Comment 9 Kyle M Hall 2015-11-20 14:56:17 UTC
Created attachment 45055 [details] [review]
Bug 14895: Removes the ability to edit already added item's info from serials-edit.pl page

Test plan:

1. In serials create a new subscription with the option "create an item record when receiving this serial" selected. You can choose the other properties.
2. Find the newly created serial subscription by using the top bar's search.
3. Click from the 'Actions' drop-down menu 'Serial receive'.
4. Change the status to 'Arrived'. Add something to the barcode field. Save.
4.1 (Optional step) Open a new tab in your browser and go see that there is in the catalogue the item you just added and it has a barcode.
5. Now you should have arrived to the page serials-collection.pl. Here, select the very same serial item you just edited and click 'Edit serials'
6. Now click just save button without doing any changes.
7. Go to find that item from the biblio record. Notice its barcode is missing now.
8. Apply the patch
9. Put there some barcode to the item manually.
9. Go back to the serials-collection.pl page and select the item and click
   'Edit serials'.
10. Click save on the edit-serials.pl page without changing any information.
11. Go and check that the item has still its barcode.
12. Find out if this patch's changes to edit-serials.pl has caused some
    problems in other parts of the system.

Signed-off-by: Liz Rea <liz@catalyst.net.nz>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 10 Kyle M Hall 2015-11-20 14:56:24 UTC
Created attachment 45056 [details] [review]
Bug 14895 [QA Followup] - Fix indentation for readability

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 11 Kyle M Hall 2015-11-20 15:35:59 UTC
Considering bug 15030 is in active development, we should probably wait to see if that one takes care of this bug.
Comment 12 Koha Team University Lyon 3 2018-09-15 17:38:08 UTC
I can't reproduce this one. Could some else test it ?
cc Claire as she's a bug wrangler.
Comment 13 Claire Gravely 2018-09-15 18:47:34 UTC
(In reply to Koha Team Lyon 3 from comment #12)
> I can't reproduce this one. Could some else test it ?
> cc Claire as she's a bug wrangler.

I couldn't reproduce it either. Most likely fixed by 15030