| Summary: | Overdues are not listed if due on 23:59 of the 'to date' (Was: Remove C4::Dates from circ/overdue.pl) | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marc Véron <veron> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | hector.hecaxmmx, jonathan.druart, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 14870 | ||
| Attachments: |
Bug 14916 - Remove C4::Dates from circ/overdue.pl
Bug 14916 - Remove C4::Dates from circ/overdue.pl [SIGNED-OFF]Bug 14916 - Remove C4::Dates from circ/overdue.pl Bug 14916: Display overdues if due on 23:59 Bug 14916: Display overdues if due on 23:59 [PASSED QA] Bug 14916: Display overdues if due on 23:59 |
||
|
Description
Marc Véron
2015-09-28 14:43:13 UTC
Created attachment 42927 [details] [review] Bug 14916 - Remove C4::Dates from circ/overdue.pl Patch to remove deprectated C4::Dates from circ/overdue.pl To test: - Tests without patch: - Make sure that you have patron(s) with overdues. - Go to Home > Circulation > Overdues - Apply date filter, perform CSV download Apply patch, then - Reload page - Check that everything behaves as before Created attachment 42928 [details] [review] Bug 14916 - Remove C4::Dates from circ/overdue.pl Patch to remove deprectated C4::Dates from circ/overdue.pl To test: - Tests without patch: - Make sure that you have patron(s) with overdues. - Go to Home > Circulation > Overdues - Apply date filter, perform CSV download Apply patch, then - Reload page - Check that everything behaves as before Created attachment 43344 [details] [review] [SIGNED-OFF]Bug 14916 - Remove C4::Dates from circ/overdue.pl Patch to remove deprectated C4::Dates from circ/overdue.pl To test: - Tests without patch: - Make sure that you have patron(s) with overdues. - Go to Home > Circulation > Overdues - Apply date filter, perform CSV download Apply patch, then - Reload page - Check that everything behaves as before Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Tested with dateformat syspref Created attachment 43375 [details] [review] Bug 14916: Display overdues if due on 23:59 If an item is due on today 23:59 and the filter is from yesterday to today, the overdue won't appear on the list. Test plan: Be sure you have an item due on DATE 23:59 Search for overdues from DATE-1 to DATE Without this patch, the item won't appear. With this patch, it will. Regression test: test the CSV download. Note: On the way, this patch remove the deps to C4::Dates (which was the original goal of the bug report). Marc, Sorry to steal your bug (again), but I think I have found a bug on master. Could you please confirm? Hi Jonathan, No problem, steal as much as you like :-) And confirmed, sign-off follows. Created attachment 43405 [details] [review] Bug 14916: Display overdues if due on 23:59 If an item is due on today 23:59 and the filter is from yesterday to today, the overdue won't appear on the list. Test plan: Be sure you have an item due on DATE 23:59 Search for overdues from DATE-1 to DATE Without this patch, the item won't appear. With this patch, it will. Regression test: test the CSV download. Note: On the way, this patch remove the deps to C4::Dates (which was the original goal of the bug report). Issue reproduced, it's resloved with this patch. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 43567 [details] [review] [PASSED QA] Bug 14916: Display overdues if due on 23:59 If an item is due today 23:59 and the filter is from yesterday to today, the overdue won't appear on the list. Test plan: Be sure you have an item due on DATE 23:59 Search for overdues from DATE-1 to DATE Without this patch, the item won't appear. With this patch, it will. Regression test: test the CSV download. Note: On the way, this patch remove the deps to C4::Dates (which was the original goal of the bug report). Issue reproduced, it's resolved with this patch. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patch pushed to master. Thanks Jonathan! |