Bug 14916

Summary: Overdues are not listed if due on 23:59 of the 'to date' (Was: Remove C4::Dates from circ/overdue.pl)
Product: Koha Reporter: Marc Véron <veron>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: hector.hecaxmmx, jonathan.druart, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 14870    
Attachments: Bug 14916 - Remove C4::Dates from circ/overdue.pl
Bug 14916 - Remove C4::Dates from circ/overdue.pl
[SIGNED-OFF]Bug 14916 - Remove C4::Dates from circ/overdue.pl
Bug 14916: Display overdues if due on 23:59
Bug 14916: Display overdues if due on 23:59
[PASSED QA] Bug 14916: Display overdues if due on 23:59

Description Marc Véron 2015-09-28 14:43:13 UTC
Patch to remove deprectated C4::Dates from circ/overdue.pl
Comment 1 Marc Véron 2015-09-28 14:52:52 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2015-09-28 14:57:37 UTC Comment hidden (obsolete)
Comment 3 Héctor Eduardo Castro Avalos 2015-10-12 15:47:58 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2015-10-13 10:24:38 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2015-10-13 10:25:45 UTC
Marc,
Sorry to steal your bug (again), but I think I have found a bug on master.
Could you please confirm?
Comment 6 Marc Véron 2015-10-14 17:16:28 UTC
Hi Jonathan,

No problem, steal as much as you like :-)

And confirmed, sign-off follows.
Comment 7 Marc Véron 2015-10-14 17:17:37 UTC Comment hidden (obsolete)
Comment 8 Katrin Fischer 2015-10-18 10:55:15 UTC
Created attachment 43567 [details] [review]
[PASSED QA] Bug 14916: Display overdues if due on 23:59

If an item is due today 23:59 and the filter is from yesterday
to today, the overdue won't appear on the list.

Test plan:
Be sure you have an item due on DATE 23:59
Search for overdues from DATE-1 to DATE
Without this patch, the item won't appear.
With this patch, it will.

Regression test: test the CSV download.

Note: On the way, this patch remove the deps to C4::Dates
(which was the original goal of the bug report).

Issue reproduced, it's resolved with this patch.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 9 Tomás Cohen Arazi 2015-10-19 14:55:22 UTC
Patch pushed to master.

Thanks Jonathan!