Bug 14966

Summary:	Table header broken at detail.tt
Product:	Koha	Reporter:	Rafal Kopaczka <rkopaczka>
Component:	Templates	Assignee:	Rafal Kopaczka <rkopaczka>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	trivial
Priority:	P5 - low	CC:	chris, jonathan.druart, liz, tomascohen
Version:	Main
Hardware:	All
OS:	All
See Also:	http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14354
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Bug Depends on:
Bug Blocks:	15256
Attachments:	screenshot Bug 14966:Table header broken at detail.tt Bug 14966:Table header broken at detail.tt [PASSED QA] Bug 14966:Table header broken at detail.tt

Description Rafal Kopaczka 2015-10-06 13:19:11 UTC

Created attachment 43168 [details]
screenshot

After Bug 14354, when user without permission to edit items, goes to page:
/cgi-bin/koha/catalogue/detail.pl?biblionumber=xxx, table with item info is corrupted. See screenshot attached. 
Looks like additional '<td>', are unnecessary.
A patch will follow.

Comment 1 Rafal Kopaczka 2015-10-06 13:21:58 UTC Comment hidden (obsolete)

Created attachment 43170 [details] [review]
Bug 14966:Table header broken at detail.tt

For user without item edit permission, table at catalogue/detail.pl is
corrupted.

Test plan:
1) Log in as staff member, without edit item permission.
2) Go to biblio view, with items attached:
/cgi-bin/koha/catalogue/detail.pl?biblionumber=X. Confirm that table
does not display correctly.
3) Apply patch.
4) Repeat steps 1 and 2. Confirm patch works.

Comment 2 Jonathan Druart 2015-10-06 13:34:56 UTC Comment hidden (obsolete)

Created attachment 43172 [details] [review]
Bug 14966:Table header broken at detail.tt

For user without item edit permission, table at catalogue/detail.pl is
corrupted.

Test plan:
1) Log in as staff member, without edit item permission.
2) Go to biblio view, with items attached:
/cgi-bin/koha/catalogue/detail.pl?biblionumber=X. Confirm that table
does not display correctly.
3) Apply patch.
4) Repeat steps 1 and 2. Confirm patch works.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Comment 3 Jonathan Druart 2015-10-09 11:05:36 UTC

This one fixes a regression on stable branches 3.20.x and 3.18.x and should be backported on the next release.

Comment 4 Katrin Fischer 2015-10-12 05:26:39 UTC

Created attachment 43325 [details] [review]
[PASSED QA] Bug 14966:Table header broken at detail.tt

For user without item edit permission, table at catalogue/detail.pl is
corrupted.

Test plan:
1) Log in as staff member, without edit item permission.
2) Go to biblio view, with items attached:
/cgi-bin/koha/catalogue/detail.pl?biblionumber=X. Confirm that table
does not display correctly.
3) Apply patch.
4) Repeat steps 1 and 2. Confirm patch works.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 5 Tomás Cohen Arazi (tcohen) 2015-10-13 15:22:43 UTC

Patch pushed to master.

Thanks Rafal!

Comment 6 Chris Cormack 2015-10-24 07:41:19 UTC

Pushed to 3.20.x will be in 3.20.5

Comment 7 Liz Rea 2015-11-25 20:33:37 UTC

This was released in 3.18.12 - sorry I missed it when I was updating bugs.

Liz