| Summary: | patron card creator not displaying correct cardnumber | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Liz Rea <liz> |
| Component: | Tools | Assignee: | Galen Charlton <gmcharlt> |
| Status: | CLOSED INVALID | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | veron, wizzyrea |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14676 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
|
Description
Liz Rea
2015-10-08 23:33:44 UTC
Card number is the position number in the batch.
It comes from:
koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt Line 215
[% SWITCH header_field.field_label -%]
[% CASE "Card Number" -%]
<th>Card number</th>
^-----------------------
patroncards/edit-batch.pl Line 50
my $display_columns = [ {_card_number => {label => 'Card Number', (...)
^----------------------
Line 138 get_card_summary
^----------------------
C4/Creators/Lib.pm
get_card_summary:
This function returns an arrayref whose elements are hashes containing the label_ids of current cards along with the item count
Line 367 :
my $card_number = 0;
(...)
foreach my $item (@{$params{'items'}}) {
$card_number++;
(...)
my $card_summary->{'_card_number'} = $card_number;
Fazit:
Quick string fix would be to change edit-batch.cc
More comprensible / sustainable fix would be to change edit-batch.pl and Lib.pm as well.
Typo:
Quick string fix would be to change edit-batch.cc
^^
edit-bach.tt
Ah right. Well that's still a little silly. I'm doing heaps of stuff in there atm, maybe I'll fix it. :) Some more findings: In label batches, the column is called 'Label number', I think the internals are similar to patron cards. The patron cards and labels are printed in this order. It would be a good idea to have the same column name for both. Maybe something like 'Item Number'. 'Position' or 'Batch position' would collide with the meaning of 'Position' while exporting labels: "Enter starting label position (PDF)" i.e. the position where the first batch item will be printed on the paper / printing form (see Bug 8796). Hm, but you can't change it, and it is basically the order the items are added... Idk, I suppose I'm questioning why we need to display it at all. It would, in fact, be good to make it consistent between the label creator and patron card creator. That is if we don't remove the display entirely. I also was thinking about not displaying this column. Hmm, we can sort the colums e.g. alphabetically by name (in the table only, not for printing), so it might be needed to switch back to the order 'how I added items'. It would be a big enhancement (and quite a task) - to have te possibility to print in different orders - to be able to move an item inside the 'added' batch position Hmm, at the moment I propose to change the template files only (string change for the headers to avoid user confusion) and to postpone the rest. This bug seems no longer to be valid. Liz, can you confirm? |