Bug 15028

Summary: t/db_dependent/Letters.t should set the numbering pattern it needs
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Test SuiteAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Galen Charlton <gmcharlt>
Severity: normal    
Priority: P5 - low CC: katrin.fischer, kyle.m.hall, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 15028: tests - force the numbering pattern to 'No. {X}'
Bug 15028: Make t/db_dependent/Letters.t set the numbering pattern it needs
[PASSED QA] Bug 15028: Make t/db_dependent/Letters.t set the numbering pattern it needs

Description Jonathan Druart 2015-10-19 13:37:45 UTC
The 3.22 release is coming and Jenkins is not happy at all (http://jenkins.koha-community.org/).
All tests should pass before the release!
Comment 1 Jonathan Druart 2015-10-19 13:38:47 UTC
This is obviously caused because our test suite is dependent of the data of a given DB (see bug 10273).
Comment 2 Jonathan Druart 2015-10-19 13:44:30 UTC Comment hidden (obsolete)
Comment 3 Tomás Cohen Arazi 2015-10-19 14:45:06 UTC Comment hidden (obsolete)
Comment 4 Kyle M Hall 2015-10-19 14:50:51 UTC
Created attachment 43596 [details] [review]
[PASSED QA] Bug 15028: Make t/db_dependent/Letters.t set the numbering pattern it needs

On some jenkins DBs, this pattern is "No.{X}" instead of "No. {X}" and
the test fails ("Serial notification text constructed successfully").

Tests should always create their own data.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Tomás Cohen Arazi 2015-10-19 14:56:08 UTC
Patch pushed to master.

Thanks Jonathan!