Bug 15028 - t/db_dependent/Letters.t should set the numbering pattern it needs
Summary: t/db_dependent/Letters.t should set the numbering pattern it needs
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Galen Charlton
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-19 13:37 UTC by Jonathan Druart
Modified: 2016-06-21 21:40 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 15028: tests - force the numbering pattern to 'No. {X}' (956 bytes, patch)
2015-10-19 13:44 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15028: Make t/db_dependent/Letters.t set the numbering pattern it needs (1.05 KB, patch)
2015-10-19 14:45 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
[PASSED QA] Bug 15028: Make t/db_dependent/Letters.t set the numbering pattern it needs (1.14 KB, patch)
2015-10-19 14:50 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2015-10-19 13:37:45 UTC
The 3.22 release is coming and Jenkins is not happy at all (http://jenkins.koha-community.org/).
All tests should pass before the release!
Comment 1 Jonathan Druart 2015-10-19 13:38:47 UTC
This is obviously caused because our test suite is dependent of the data of a given DB (see bug 10273).
Comment 2 Jonathan Druart 2015-10-19 13:44:30 UTC Comment hidden (obsolete)
Comment 3 Tomás Cohen Arazi 2015-10-19 14:45:06 UTC Comment hidden (obsolete)
Comment 4 Kyle M Hall 2015-10-19 14:50:51 UTC
Created attachment 43596 [details] [review]
[PASSED QA] Bug 15028: Make t/db_dependent/Letters.t set the numbering pattern it needs

On some jenkins DBs, this pattern is "No.{X}" instead of "No. {X}" and
the test fails ("Serial notification text constructed successfully").

Tests should always create their own data.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Tomás Cohen Arazi 2015-10-19 14:56:08 UTC
Patch pushed to master.

Thanks Jonathan!