Description
Tomás Cohen Arazi (tcohen)
2015-10-20 13:58:47 UTC
Could you please detail? The tab is hidden for me. Steps to reproduce: - Set BatchCheckouts to "allow" - Set BatchCheckoutsValidCategories to ST - Have a patron in another category (for example S) - Go to that patron details => FAIL: You can see the "Batch checkouts" tab, if you choose it, Koh correctly says that patron category cannot be used for batch checkouts. That's how I have tested, and it works here, weird. Created attachment 43692 [details] [review] Bug 15037: Correctly check the patron categories on displaying the Batch checkout tab When checking for the patron categories allowed to use the batch checkout, the comparison should be strict (eq). Test plan: 0/ Do not apply this patch 1/ Create 2 patron categories ST and S 2/ Enable BatchCheckouts and define BatchCheckoutsValidCategories = S 3/ Create 2 patrons, 1 in the ST category and the other one in S 4/ On the patron detail page, you should see the "batch checkout" tab for both patron 5/ Apply this patch 6/ The tab should only be displayed for the patron S Created attachment 43702 [details] [review] Bug 15037: Correctly check the patron categories on displaying the Batch checkout tab When checking for the patron categories allowed to use the batch checkout, the comparison should be strict (eq). Test plan: 0/ Do not apply this patch 1/ Create 2 patron categories ST and S 2/ Enable BatchCheckouts and define BatchCheckoutsValidCategories = S 3/ Create 2 patrons, 1 in the ST category and the other one in S 4/ On the patron detail page, you should see the "batch checkout" tab for both patron 5/ Apply this patch 6/ The tab should only be displayed for the patron S Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Tested using an 'S' patron and allowing 'ST' patrons only, worked as expected. Also tried setting &batch=1 to force it to show the batch page, and it says I'm not allowed to do batch checkouts for that patron. Great! Created attachment 43815 [details] [review] [PASSED QA] Bug 15037: Correctly check the patron categories on displaying the Batch checkout tab When checking for the patron categories allowed to use the batch checkout, the comparison should be strict (eq). Test plan: 0/ Do not apply this patch 1/ Create 2 patron categories ST and S 2/ Enable BatchCheckouts and define BatchCheckoutsValidCategories = S 3/ Create 2 patrons, 1 in the ST category and the other one in S 4/ On the patron detail page, you should see the "batch checkout" tab for both patron 5/ Apply this patch 6/ The tab should only be displayed for the patron S Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Tested using an 'S' patron and allowing 'ST' patrons only, worked as expected. Also tried setting &batch=1 to force it to show the batch page, and it says I'm not allowed to do batch checkouts for that patron. Great! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 43816 [details] [review] [PASSED QA] Bug 15037: Correctly check the patron categories on displaying the Batch checkout tab When checking for the patron categories allowed to use the batch checkout, the comparison should be strict (eq). Test plan: 0/ Do not apply this patch 1/ Create 2 patron categories ST and S 2/ Enable BatchCheckouts and define BatchCheckoutsValidCategories = S 3/ Create 2 patrons, 1 in the ST category and the other one in S 4/ On the patron detail page, you should see the "batch checkout" tab for both patron 5/ Apply this patch 6/ The tab should only be displayed for the patron S Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Tested using an 'S' patron and allowing 'ST' patrons only, worked as expected. Also tried setting &batch=1 to force it to show the batch page, and it says I'm not allowed to do batch checkouts for that patron. Great! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch pushed to master. Thanks Jonathan! |