| Summary: | Line break in html attribute | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
| Component: | Templates | Assignee: | Fridolin Somers <fridolin.somers> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | jonathan.druart, liz, tomascohen, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 15059 - Line break in html attribute
Bug 15059 - Line break in html attribute Bug 15059 - Line break in html attribute in branchoverdues.tt Bug 15059 - Line break in html attribute in branchoverdues.tt Bug 15059 - Line break in html attribute in branchoverdues.tt |
||
|
Description
Fridolin Somers
2015-10-26 07:43:08 UTC
Created attachment 43973 [details] [review] Bug 15059 - Line break in html attribute In some templates, there is a line break inside href attribute. This generates an attribute with a lot of spaces %20. Test plan : - at intranet (same at OPAC) - perform a search on one word with a sort order (anything but relevance) - click on "Next" at the bottom of the page - look at link "Show more" in facets => Without patch the URL contains a lot of spaces => With patch the URL is correct - at intranet go to ciculation module - click on "Overdues with fines" - look at links "Phone", "Notice" and "Considered lost" => Without patch the URL contains a lot of spaces => With patch the URL is correct Created attachment 44042 [details] [review] Bug 15059 - Line break in html attribute In some templates, there is a line break inside href attribute. This generates an attribute with a lot of spaces %20. Test plan : - at intranet (same at OPAC) - perform a search on one word with a sort order (anything but relevance) - click on "Next" at the bottom of the page - look at link "Show more" in facets => Without patch the URL contains a lot of spaces => With patch the URL is correct - at intranet go to ciculation module - click on "Overdues with fines" - look at links "Phone", "Notice" and "Considered lost" => Without patch the URL contains a lot of spaces => With patch the URL is correct Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 44106 [details] [review] Bug 15059 - Line break in html attribute in branchoverdues.tt In circ/branchoverdues.tt, there is a line break inside href attribute. This generates an attribute with a lot of spaces %20. Test plan : - at intranet go to ciculation module - click on "Overdues with fines" - look at links "Phone", "Notice" and "Considered lost" => Without patch the URL contains a lot of spaces => With patch the URL is correct (In reply to Jonathan Druart from comment #3) > Please provide a fix on top of bug 14955 Super, Bug 14955 fixes the facets includes. This patch will only fix branchoverdues.tt (In reply to Fridolin SOMERS from comment #5) > (In reply to Jonathan Druart from comment #3) > > Please provide a fix on top of bug 14955 > > Super, Bug 14955 fixes the facets includes. > This patch will only fix branchoverdues.tt In this case, this bug can be tested without bug 14955. Created attachment 44112 [details] [review] Bug 15059 - Line break in html attribute in branchoverdues.tt In circ/branchoverdues.tt, there is a line break inside href attribute. This generates an attribute with a lot of spaces %20. Test plan : - at intranet go to ciculation module - click on "Overdues with fines" - look at links "Phone", "Notice" and "Considered lost" => Without patch the URL contains a lot of spaces => With patch the URL is correct Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 44193 [details] [review] Bug 15059 - Line break in html attribute in branchoverdues.tt In circ/branchoverdues.tt, there is a line break inside href attribute. This generates an attribute with a lot of spaces %20. Test plan : - at intranet go to ciculation module - click on "Overdues with fines" - look at links "Phone", "Notice" and "Considered lost" => Without patch the URL contains a lot of spaces => With patch the URL is correct Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Does this one really depend on 14955? Patch pushed to master. Thanks Frido! Pushed to 3.18.13, and released. |