| Summary: | Hide search header text boxes on render | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Christopher Brannon <cbrannon> |
| Component: | Staff interface | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | brendan, f.demians, gmcharlt, hector.hecaxmmx, jonathan.druart, julian.maurice, veron |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 15119: Hide search header text boxes on render
[SIGNED-OFF]Bug 15119: Hide search header text boxes on render [SIGNED-OFF] Bug 15119: Hide search header text boxes on render Bug 15119: Hide search header text boxes on render [PASSED QA] Bug 15119: Hide search header text boxes on render |
||
|
Description
Christopher Brannon
2015-11-03 22:38:59 UTC
Created attachment 46325 [details] [review] Bug 15119: Hide search header text boxes on render When the page rendering is slow or the page is heavy, the tabs in the header shown be not correctly displayed as tabs. This patch suggests to hide them, display the first one, and wait for the JS code to display them nicely. To easily reproduced the ergonomic issue, go on the circulation home page (/cgi-bin/koha/circ/circulation.pl) and search for a patron 'a' or 'd', you will get a lot of result and the page will be slow to be fully displayed. Hi Jonathan, I have an old computer and always render slowly, but i can't reproduce the issue, or I misunderstand the main problem. Regards (In reply to Héctor Eduardo Castro Avalos from comment #2) > Hi Jonathan, I have an old computer and always render slowly, but i can't > reproduce the issue, or I misunderstand the main problem. > > Regards Ahh... Ok I needed to delete my cookies. Or erase my browsing history Created attachment 46377 [details] [review] [SIGNED-OFF]Bug 15119: Hide search header text boxes on render When the page rendering is slow or the page is heavy, the tabs in the header shown be not correctly displayed as tabs. This patch suggests to hide them, display the first one, and wait for the JS code to display them nicely. To easily reproduced the ergonomic issue, go on the circulation home page (/cgi-bin/koha/circ/circulation.pl) and search for a patron 'a' or 'd', you will get a lot of result and the page will be slow to be fully displayed. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Thanks for testing Héctor. Switch back to Needs Signoff, I would like to get one from Christopher. (In reply to Jonathan Druart from comment #6) > Thanks for testing Héctor. > Switch back to Needs Signoff, I would like to get one from Christopher. Okidoki What is the status of this bug? (In reply to Marc Véron from comment #8) > What is the status of this bug? Needs Signoff, I would like to get one from Christopher. Created attachment 48965 [details] [review] [SIGNED-OFF] Bug 15119: Hide search header text boxes on render When the page rendering is slow or the page is heavy, the tabs in the header shown be not correctly displayed as tabs. This patch suggests to hide them, display the first one, and wait for the JS code to display them nicely. To easily reproduced the ergonomic issue, go on the circulation home page (/cgi-bin/koha/circ/circulation.pl) and search for a patron 'a' or 'd', you will get a lot of result and the page will be slow to be fully displayed. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Owen Leonard <oleonard@myacpl.org> I see no change with patch applied. Attaching video to patch to show my results. Christopher Actually, I did a screencast. You can see the results here: http://screencast.com/t/eP9RRvUp Christopher Seems to work for me on sandbox6, confirm you have correctly flushed your browser cache. (In reply to Jonathan Druart from comment #13) > Seems to work for me on sandbox6, confirm you have correctly flushed your > browser cache. Ugh! Stupid cache. It works now. :/ I'll sign off on it. Christopher Created attachment 48988 [details] [review] Bug 15119: Hide search header text boxes on render When the page rendering is slow or the page is heavy, the tabs in the header shown be not correctly displayed as tabs. This patch suggests to hide them, display the first one, and wait for the JS code to display them nicely. To easily reproduced the ergonomic issue, go on the circulation home page (/cgi-bin/koha/circ/circulation.pl) and search for a patron 'a' or 'd', you will get a lot of result and the page will be slow to be fully displayed. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Created attachment 49344 [details] [review] [PASSED QA] Bug 15119: Hide search header text boxes on render When the page rendering is slow or the page is heavy, the tabs in the header shown be not correctly displayed as tabs. This patch suggests to hide them, display the first one, and wait for the JS code to display them nicely. To easily reproduced the ergonomic issue, go on the circulation home page (/cgi-bin/koha/circ/circulation.pl) and search for a patron 'a' or 'd', you will get a lot of result and the page will be slow to be fully displayed. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to Master - Should be in the May 2016 release. Thanks! Patch pushed to 3.22.x, will be in 3.22.5 Pushed to 3.20.x, will be in 3.20.10 |