Summary: | List email sent from staff is missing ISBN and author information | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Lists | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | bgkriegel, f.demians, jonathan.druart, liz, m.de.rooy, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 15137: Display ISBN and author info when sending list by email
[SIGNED-OFF] Bug 15137: Display ISBN and author info when sending list by email [PASSED QA] Bug 15137: Display ISBN and author info when sending list by email |
Description
Katrin Fischer
2015-11-05 11:22:49 UTC
Created attachment 44846 [details] [review] Bug 15137: Display ISBN and author info when sending list by email Disclaimer: this is not caused by bug 14544 :) And can be backported! Both isbn and author information are missing when a list is sent by email. Emails sent from OPAC and staff should be (almost) the same. Test plan: 1/ Sent a list by email (Button "Send list") 2/ The email you will receive should contain the isbn and author info It would be worth having it in 3.22. Hi, on current master I get "Can't call method "get_contents" on an undefined value at $home/kohaclone/virtualshelves/sendshelf.pl line 74" when sending a list from staff From opac I can send the list with authors and isbn without patch This patch is for opac, staff or both? (In reply to Bernardo Gonzalez Kriegel from comment #3) > Hi, on current master I get > "Can't call method "get_contents" on an undefined value at > $home/kohaclone/virtualshelves/sendshelf.pl line 74" > when sending a list from staff > > From opac I can send the list with authors and isbn without patch > > This patch is for opac, staff or both? For staff only, it works without this patch at the OPAC. The error you reported should have been fixed by the patch I have submitted yesterday on bug 14544 comment 242. Created attachment 44862 [details] [review] [SIGNED-OFF] Bug 15137: Display ISBN and author info when sending list by email Disclaimer: this is not caused by bug 14544 :) And can be backported! Both isbn and author information are missing when a list is sent by email. Emails sent from OPAC and staff should be (almost) the same. Test plan: 1/ Sent a list by email (Button "Send list") 2/ The email you will receive should contain the isbn and author info Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> On top of last patch of Bug 14544 Works ok, mail with authors and ISBN No errors Created attachment 44871 [details] [review] [PASSED QA] Bug 15137: Display ISBN and author info when sending list by email Disclaimer: this is not caused by bug 14544 :) And can be backported! Both isbn and author information are missing when a list is sent by email. Emails sent from OPAC and staff should be (almost) the same. Test plan: 1/ Sent a list by email (Button "Send list") 2/ The email you will receive should contain the isbn and author info Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> On top of last patch of Bug 14544 Works ok, mail with authors and ISBN No errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patch pushed to master. Thanks Jonathan! This patch has been pushed to 3.20.x, will be in 3.20.6. Pushed to 3.18.13, and released. |