Bug 15168

Summary: Remove C4::Serials::ItemizeSerials which is not used anymore
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: tomascohen, veron
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 14969, 21171    
Attachments: Bug 15168: Remove C4:Serials::ItemizeSerials
Bug 15168: Remove C4:Serials::ItemizeSerials
[PASSED QA] Bug 15168: Remove C4:Serials::ItemizeSerials
Bug 15168: (followup) remove useless diags

Description Jonathan Druart 2015-11-11 08:55:14 UTC

    
Comment 1 Jonathan Druart 2015-11-11 09:00:30 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2015-11-11 10:29:38 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2015-11-11 21:17:32 UTC
Created attachment 44778 [details] [review]
[PASSED QA] Bug 15168: Remove C4:Serials::ItemizeSerials

This subroutine has been introduced in 2006, when C4::Serials has been
added to the codebase.
If you checkout this commit
commit 18d2cd099085e443d713a1546e029faa81481814
Date:   Fri Jul 7 08:45:47 2006 +0000
    this file replace C4/Bull.pm

You won't find any occurrences of this subroutine neither.

Interesting module's name by the way.

Test plan:
  git grep ItemizeSerials
should not return any result

Followed test plan, no results found.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2015-11-17 18:51:10 UTC
Created attachment 44935 [details] [review]
Bug 15168: (followup) remove useless diags

While testing this bug I noticed the tests printed useless diags.
This patch removes them for good.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 5 Tomás Cohen Arazi 2015-11-17 18:52:33 UTC
Patch pushed to master.

Thanks Jonathan!