Bug 21171 - Remove C4::Serials::is_barcode_in_use which is not used anymore
Summary: Remove C4::Serials::is_barcode_in_use which is not used anymore
Status: RESOLVED DUPLICATE of bug 21154
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 15168
Blocks:
  Show dependency treegraph
 
Reported: 2018-08-07 19:34 UTC by Jonathan Druart
Modified: 2018-11-29 11:15 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 21171: Remove C4::Serials::is_barcode_in_use (1.25 KB, patch)
2018-08-07 19:36 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2018-08-07 19:34:51 UTC
Bug 15168 removed C4::Serials::ItemizeSerials, it was the only place where C4::Serials::is_barcode_in_use was used.
Comment 1 Jonathan Druart 2018-08-07 19:36:49 UTC
Created attachment 77543 [details] [review]
Bug 21171: Remove C4::Serials::is_barcode_in_use

Bug 15168 removed C4::Serials::ItemizeSerials, it was the only place
where C4::Serials::is_barcode_in_use was used.

Test plan:
  git grep is_barcode_in_use
should not return anything
  prove -r t/db_dependent/Serials*
should return green
Comment 2 Devinim 2018-11-19 12:50:29 UTC
All tests successful.
Files=9, Tests=375, 15 wallclock secs ( 0.08 usr  0.01 sys + 10.88 cusr  0.82 csys = 11.79 CPU)
Result: PASS

I didnot realize why no one isn't signedoff this?
Comment 3 Marcel de Rooy 2018-11-29 11:15:04 UTC

*** This bug has been marked as a duplicate of bug 21154 ***