Comment on attachment 44888 [details]
patron modifications
I think we accidentally added the same feature twice there - one could be removed.
commit 49fa3c0d08232e6d44f82e6827cedb076bcdbdd7
Bug 10904: Limit patron update request management by branch
commit d49cba287e46b4c1e6656f9ec2c1867bfd633016
Bug 12352: Patron modification request page: Add link to patron record
(In reply to Katrin Fischer from comment #1)
> I think we accidentally added the same feature twice there - one could be
> removed.
Which one?
Created attachment 46838 [details] [review] Bug 15195 - patron details should open in tab Deleted View record link and made patron details open in a new tab. To Test: Edit personal details for a user on opac and submit update request. In staff client go to patrons requesting modifications. Confirm To Test: Edit personal details for a user on opac and submit update request. In staff client go to patrons requesting modifications. Confirm View record link is gone and patron details opens in a new tab. Created attachment 46905 [details] [review] [SIGNED-OFF] Bug 15195 - patron details should open in tab Deleted View record link and made patron details open in a new tab. To Test: Edit personal details for a user on opac and submit update request. In staff client go to patrons requesting modifications. Confirm view record link is gone and patron details opens in new tab. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 46908 [details] [review] Bug 15195 - patron details should open in tab Deleted View record link and made patron details open in a new tab. To Test: Edit personal details for a user on opac and submit update request. In staff client go to patrons requesting modifications. Confirm view record link is gone and patron details opens in new tab. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> I don't think it's a good idea to open a new tab (let the user decide) but the behavior already existed before this patch. Pushed to Master - Should be in the may 2016 release. Thanks! Patch pushed to 3.22.x, will be in 3.22.3 |
Created attachment 44888 [details] patron modifications When looking at patron modification requests the 'view record' link opens in a new tab, but the 'patron details' link doesn't. I'm not sure we need both links anyway, but if we have them both they should open in a new tab. Nicole