Bug 15199

Summary: t/db_dependent/Review.t should not depend on existing data
Product: Koha Reporter: Tomás Cohen Arazi <tomascohen>
Component: Test SuiteAssignee: Tomás Cohen Arazi <tomascohen>
Status: CLOSED FIXED QA Contact: Galen Charlton <gmcharlt>
Severity: normal    
Priority: P5 - low CC: hector.hecaxmmx, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 15199: t/db_dependent/Review.t should not depend on existing data
[SIGNED-OFF]Bug 15199: t/db_dependent/Review.t should not depend on existing data
[PASSED QA] Bug 15199: t/db_dependent/Review.t should not depend on existing data

Description Tomás Cohen Arazi 2015-11-17 13:20:44 UTC
It currently depends on existing patrons and categories.
Comment 1 Tomás Cohen Arazi 2015-11-17 13:24:09 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2015-11-17 16:20:31 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2015-11-18 01:29:34 UTC
Created attachment 44942 [details] [review]
[PASSED QA] Bug 15199: t/db_dependent/Review.t should not depend on existing data

This patch makes the tests create a branch and a patron category instead
of searching for them on the DB.

To test:
- Apply the patch on current master
- Run
  $ prove t/db_dependent/Review.t
=> SUCCESS: Tests pass
- Sign off

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
All test pass successful

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2015-11-18 02:47:36 UTC
Patch pushed to master.