Created attachment 45087 [details] [review] Bug 15231 - Import patrons: Remove string splitting by html tags to avoid weird translations Some of the strings in Home > Tools > Import patrons contain html tags and therefore are splitted in the translation tool. This makes it nearly impossible to create correct translations from the partial strings. Additinally, the notes for Extended patron attributes never displayed (due to a bug). To test: - Apply patch - Enable Syspref 'ExtendedPAtronAttributes' - Go to Home > Tools > Import patrons and verify, that the Notes at the right of the screen make sense Created attachment 45092 [details] [review] [SIGNED-OFF]Bug 15231 - Import patrons: Remove string splitting by html tags to avoid weird translations Some of the strings in Home > Tools > Import patrons contain html tags and therefore are splitted in the translation tool. This makes it nearly impossible to create correct translations from the partial strings. Additinally, the notes for Extended patron attributes never displayed (due to a bug). To test: - Apply patch - Enable Syspref 'ExtendedPAtronAttributes' - Go to Home > Tools > Import patrons and verify, that the Notes at the right of the screen make sense Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Split html tags removed, notes at right side it displayed correctly Katrin, Nicole, Could we get your opinion on this change please? Changes look good to me - I like the clearer structure. I think I found a small mistake, a stray </b> tag: <ul><li>Example 1: INSTID:12345,LANG:fr</b></li><li> Created attachment 45343 [details] [review] Bug 15231: (followup) Remove stray </b> tag This patch removes a stray </b> tag (see comment #4) and a superfluous blank. Created attachment 45346 [details] [review] [SIGNED-OFF]Bug 15231: (followup) Remove stray </b> tag This patch removes a stray </b> tag (see comment #4) and a superfluous blank. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Created attachment 45441 [details] [review] Bug 15231 - Import patrons: Remove string splitting by html tags to avoid weird translations Some of the strings in Home > Tools > Import patrons contain html tags and therefore are splitted in the translation tool. This makes it nearly impossible to create correct translations from the partial strings. Additinally, the notes for Extended patron attributes never displayed (due to a bug). To test: - Apply patch - Enable Syspref 'ExtendedPAtronAttributes' - Go to Home > Tools > Import patrons and verify, that the Notes at the right of the screen make sense Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Split html tags removed, notes at right side it displayed correctly Bug 15231: (followup) Remove stray </b> tag This patch removes a stray </b> tag (see comment #4) and a superfluous blank. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Squash the 2 patches Created attachment 46037 [details] [review] Bug 15301: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence The file intranet-tmpl/prog/en/modules/circ/branchtransfers.tt contains two ambiguous words 'to' and a sentence splitted up by html tags, leading to weird translations. Example in German: "Sie können keine Exemplare aus itemtype transferieren BK für: Airfield" To test: - Apply patch - Set up transfer policies for item types and collection codes in Home > Administration > Set library checkin and transfer policy Make sure that you have rules that deny and others that allow transfers - Verify that syspref 'UseBranchTransferLimits' is set to 'Enforce' - Set 'BranchTransferLimitTypes' to 'item type' - Go to Home > Circulation > Transfers - Transfer an item that is allowed for item type - Verify that the table of transferred items displays information about Item type, Collection code and Destination - Transfer an item that is not allowed for the item type - Verify that the information about not allowing the transfer displays properly and is meaningfull - Set 'BranchTransferLimitTypes' to 'collection code' - Repeat the transfer steps above for allowed / not allowed collection code (Amended to add ids to table and 8 columns, see comment #2) (Amended for comment #5) Followup for comment #8 Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Created attachment 46038 [details] [review] Bug 15231 - Import patrons: Remove string splitting by html tags to avoid weird translations Some of the strings in Home > Tools > Import patrons contain html tags and therefore are splitted in the translation tool. This makes it nearly impossible to create correct translations from the partial strings. Additinally, the notes for Extended patron attributes never displayed (due to a bug). To test: - Apply patch - Enable Syspref 'ExtendedPAtronAttributes' - Go to Home > Tools > Import patrons and verify, that the Notes at the right of the screen make sense Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Split html tags removed, notes at right side it displayed correctly Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Created attachment 46039 [details] [review] Bug 15231: (followup) Remove stray </b> tag This patch removes a stray </b> tag (see comment #4) and a superfluous blank. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Pushed to Master - thanks Patch pushed in 3.22.x, will be in 3.22.2 This patch has been pushed to 3.20.x, will be in 3.20.8. |
Some of the strings in Home > Tools > Import patrons contain html tags and therefore are splitted in the translation tool. This makes it nearly impossible to create correct translations from the partial strings. Example from 3.20: English: The fields 'branchcode' and 'categorycode' are required and must match valid entries in your database. ('required' and 'must match' are bold) German translation: Die Felder 'branchcode' und 'categorycode' sind verpflichtend und muss übereinstimmen erlaubte Eingaben in Ihre Datenbank. (Very weird).