Bug 15231 - Import patrons: Remove string splitting by html tags to avoid weird translations
Summary: Import patrons: Remove string splitting by html tags to avoid weird translations
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Marc Véron
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-22 18:17 UTC by Marc Véron
Modified: 2017-06-14 22:10 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15231 - Import patrons: Remove string splitting by html tags to avoid weird translations (5.32 KB, patch)
2015-11-22 20:12 UTC, Marc Véron
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 15231 - Import patrons: Remove string splitting by html tags to avoid weird translations (5.45 KB, patch)
2015-11-23 03:04 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 15231: (followup) Remove stray </b> tag (1.67 KB, patch)
2015-12-02 23:41 UTC, Marc Véron
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 15231: (followup) Remove stray </b> tag (1.73 KB, patch)
2015-12-03 01:49 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 15231 - Import patrons: Remove string splitting by html tags to avoid weird translations (5.70 KB, patch)
2015-12-07 09:56 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15301: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence (7.36 KB, patch)
2015-12-29 22:37 UTC, Brendan Gallagher
Details | Diff | Splinter Review
Bug 15231 - Import patrons: Remove string splitting by html tags to avoid weird translations (5.50 KB, patch)
2015-12-29 22:38 UTC, Brendan Gallagher
Details | Diff | Splinter Review
Bug 15231: (followup) Remove stray </b> tag (1.79 KB, patch)
2015-12-29 22:38 UTC, Brendan Gallagher
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2015-11-22 18:17:09 UTC
Some of the strings in Home > Tools > Import patrons contain html tags and therefore are splitted in the translation tool. This makes it nearly impossible to create correct translations from the partial strings. 

Example from 3.20:

English:
The fields 'branchcode' and 'categorycode' are required and must match valid entries in your database.
('required' and 'must match' are bold)

German translation:
Die Felder 'branchcode' und 'categorycode' sind verpflichtend und muss übereinstimmen erlaubte Eingaben in Ihre Datenbank.
(Very weird).
Comment 1 Marc Véron 2015-11-22 20:12:25 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2015-11-23 03:04:00 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2015-12-02 09:52:44 UTC
Katrin, Nicole,
Could we get your opinion on this change please?
Comment 4 Katrin Fischer 2015-12-02 23:09:13 UTC
Changes look good to me - I like the clearer structure. I think I found a small mistake, a stray </b> tag:

<ul><li>Example 1: INSTID:12345,LANG:fr</b></li><li>
Comment 5 Marc Véron 2015-12-02 23:41:49 UTC Comment hidden (obsolete)
Comment 6 Héctor Eduardo Castro Avalos 2015-12-03 01:49:37 UTC Comment hidden (obsolete)
Comment 7 Jonathan Druart 2015-12-07 09:56:42 UTC Comment hidden (obsolete)
Comment 8 Brendan Gallagher 2015-12-29 22:37:41 UTC Comment hidden (obsolete)
Comment 9 Brendan Gallagher 2015-12-29 22:38:01 UTC
Created attachment 46038 [details] [review]
Bug 15231 - Import patrons: Remove string splitting by html tags to avoid weird translations

Some of the strings in Home > Tools > Import patrons contain html tags and therefore are
splitted in the translation tool. This makes it nearly impossible to create correct translations
from the partial strings.
Additinally, the notes for Extended patron attributes never displayed (due to a bug).

To test:
- Apply patch
- Enable Syspref 'ExtendedPAtronAttributes'
- Go to Home > Tools > Import patrons and verify, that the Notes at the right of the
  screen make sense

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Split html tags removed, notes at right side it displayed correctly

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Comment 10 Brendan Gallagher 2015-12-29 22:38:26 UTC
Created attachment 46039 [details] [review]
Bug 15231: (followup) Remove stray </b> tag

This patch removes a stray </b> tag (see comment #4) and a superfluous blank.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Comment 11 Brendan Gallagher 2015-12-29 22:43:22 UTC
Pushed to Master - thanks
Comment 12 Julian Maurice 2015-12-30 16:18:09 UTC
Patch pushed in 3.22.x, will be in 3.22.2
Comment 13 Frédéric Demians 2015-12-31 18:25:20 UTC
This patch has been pushed to 3.20.x, will be in 3.20.8.