Summary: | Add column filters to checkouts table | ||
---|---|---|---|
Product: | Koha | Reporter: | Julian Maurice <julian.maurice> |
Component: | Circulation | Assignee: | Julian Maurice <julian.maurice> |
Status: | BLOCKED --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | anne-claire.bernaudin, black23, gmcharlt, harold.sabanal, jonathan.druart, kyle.m.hall, pasi.kallinen, severine.queune |
Version: | Main | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 15219 | ||
Bug Blocks: | |||
Attachments: |
Bug 15235: Add column filters to checkouts table
Bug 15235: Add column filters to checkouts table Bug 15235: Add column filters to checkouts table Bug 15235: Add column filters to checkouts table Bug 15235: Add column filters to checkouts table Bug 15235: Fix itemtype and branch filters |
Description
Julian Maurice
2015-11-23 07:51:28 UTC
Created attachment 45096 [details] [review] Bug 15235: Add column filters to checkouts table This adds a switch that allow to enable/disable column filters on checkouts table (disabled by default) Depends on bug 15219 Created attachment 60079 [details] [review] Bug 15235: Add column filters to checkouts table This adds a switch that allow to enable/disable column filters on checkouts table (disabled by default) Depends on bug 15219 Rebased on master Created attachment 61160 [details] [review] Bug 15235: Add column filters to checkouts table This adds a switch that allow to enable/disable column filters on checkouts table (disabled by default) Depends on bug 15219 Hi Julian, During Koha Conference 2017 Hackfest, we tried to test your patch on a sandbox but we got this message: Some problems occurred applying patches from bug 15235: <h1>Something went wrong !</h1>Applying: Bug 15235: Add column filters to checkouts table fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table.inc). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 15235: Add column filters to checkouts table The copy of the patch that failed is found in: /home/sandbox1/src/.git/rebase-apply/patch When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 15235 - Add column filters to checkouts table 61160 - Bug 15235: Add column filters to checkouts table Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-15235-Add-column-filters-to-checkouts-table-FaU1cI.patch. Thanks. Created attachment 72908 [details] [review] Bug 15235: Add column filters to checkouts table This adds a switch that allow to enable/disable column filters on checkouts table (disabled by default) Depends on bug 15219 Comment on attachment 72908 [details] [review] Bug 15235: Add column filters to checkouts table Shouldn't this be a translatable string? + sRangeFormat: "From {from}<br>to {to}", Hi Julian, - date filters don't work : maybe a format problem - item type, library, checked out from (and maybe location) filters don't work : maybe using the code instead of the description (LIV instead of Livre) Thanks Anne-Claire Created attachment 79205 [details] [review] Bug 15235: Add column filters to checkouts table This adds a switch that allow to enable/disable column filters on checkouts table (disabled by default) Depends on bug 15219 Created attachment 79206 [details] [review] Bug 15235: Fix itemtype and branch filters Also: - add a dropdown list of itemtypes to make it easier - make the "from... to..." string translatable (In reply to paxed from comment #7) > Comment on attachment 72908 [details] [review] [review] > Bug 15235: Add column filters to checkouts table > > Shouldn't this be a translatable string? > > + sRangeFormat: "From {from}<br>to {to}", Yes. Done in the last patch (In reply to abernaud from comment #8) > Hi Julian, > > - date filters don't work : maybe a format problem I can't reproduce the issue (tried with different values of dateformat syspref), can you give an example ? > - item type, library, checked out from (and maybe location) filters don't > work : maybe using the code instead of the description (LIV instead of Livre) This should be fixed by the last patch > > - date filters don't work : maybe a format problem
> I can't reproduce the issue (tried with different values of dateformat
> syspref), can you give an example ?
I tried with all dateformat options and only found it to work with ISO-formatted dates. Otherwise everything seemed to work really well.
This is blocked by its dependency being 'In discussion'. |