Bug 15235 - Add column filters to checkouts table
Summary: Add column filters to checkouts table
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Julian Maurice
QA Contact: Testopia
URL:
Whiteboard:
Keywords: Academy
Depends on: 15219
Blocks:
  Show dependency treegraph
 
Reported: 2015-11-23 07:51 UTC by Julian Maurice
Modified: 2018-03-16 09:06 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 15235: Add column filters to checkouts table (9.09 KB, patch)
2015-11-23 07:52 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 15235: Add column filters to checkouts table (12.62 KB, patch)
2017-02-09 15:21 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 15235: Add column filters to checkouts table (12.62 KB, patch)
2017-03-16 09:06 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 15235: Add column filters to checkouts table (12.92 KB, patch)
2018-03-15 08:45 UTC, Julian Maurice
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2015-11-23 07:51:28 UTC
When dealing with a large number of checkouts, it could be useful to filter them (before using renew/checkin/export checkboxes for instance).
Comment 1 Julian Maurice 2015-11-23 07:52:07 UTC
Created attachment 45096 [details] [review]
Bug 15235: Add column filters to checkouts table

This adds a switch that allow to enable/disable column filters on
checkouts table (disabled by default)

Depends on bug 15219
Comment 2 Julian Maurice 2017-02-09 15:21:02 UTC
Created attachment 60079 [details] [review]
Bug 15235: Add column filters to checkouts table

This adds a switch that allow to enable/disable column filters on
checkouts table (disabled by default)

Depends on bug 15219
Comment 3 Julian Maurice 2017-02-09 15:21:15 UTC
Rebased on master
Comment 4 Julian Maurice 2017-03-16 09:06:39 UTC
Created attachment 61160 [details] [review]
Bug 15235: Add column filters to checkouts table

This adds a switch that allow to enable/disable column filters on
checkouts table (disabled by default)

Depends on bug 15219
Comment 5 Harold 2017-06-23 02:46:22 UTC
Hi Julian,

During Koha Conference 2017 Hackfest, we tried to test your patch on a sandbox but we got this message:

Some problems occurred applying patches from bug 15235:
<h1>Something went wrong !</h1>Applying: Bug 15235: Add column filters to checkouts table
fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table.inc).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.

Patch failed at 0001 Bug 15235: Add column filters to checkouts table
The copy of the patch that failed is found in:
   /home/sandbox1/src/.git/rebase-apply/patch

When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Bug 15235 - Add column filters to checkouts table

61160 - Bug 15235: Add column filters to checkouts table

Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-15235-Add-column-filters-to-checkouts-table-FaU1cI.patch.


Thanks.
Comment 6 Julian Maurice 2018-03-15 08:45:51 UTC
Created attachment 72908 [details] [review]
Bug 15235: Add column filters to checkouts table

This adds a switch that allow to enable/disable column filters on
checkouts table (disabled by default)

Depends on bug 15219
Comment 7 paxed 2018-03-15 09:52:26 UTC
Comment on attachment 72908 [details] [review]
Bug 15235: Add column filters to checkouts table

Shouldn't this be a translatable string?

+            sRangeFormat: "From {from}<br>to {to}",
Comment 8 abernaud 2018-03-16 09:06:09 UTC
Hi Julian,

- date filters don't work : maybe a format problem
- item type, library, checked out from (and maybe location) filters don't work : maybe using the code instead of the description (LIV instead of Livre)

Thanks
Anne-Claire