| Summary: | Items table on detail page can be broken | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Cataloging | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | chris, f.demians, julian.maurice, kyle, liz, m.de.rooy |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 14354, 14966 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 15256: Fix items table display on the detail page
Bug 15256: Fix items table display on the detail page [PASSED QA] Bug 15256: Fix items table display on the detail page |
||
|
Description
Jonathan Druart
2015-11-25 17:08:32 UTC
Created attachment 45170 [details] [review] Bug 15256: Fix items table display on the detail page Bug 14966 fixed a bug but introduced another one: With IndependentBranches set to 'prevent', if the librarian (without the superlibrarian permission) can edit items but not all, the table is broken. DataTables raises the following warning: "DataTables warning: table id=DataTables_Table_1 - Requested unknown parameter '8' for row0." And does not display correctly. Test plan: 1/ Create a biblio record with 1+ items located in different places. 2/ Create/use a patron with the permission to edit items 3/ Set the IndependentBranches pref to 'prevent' 4/ With this patron logged in, go on the record detail page. Without this patch, the display is broken (only 1 edit link and 1 td missing, DataTables raises a warning). With this patch, the display is correct. @RM 3.20: Should be backported. @RM 3.18: Should be backported with bug 14966. Created attachment 45206 [details] [review] Bug 15256: Fix items table display on the detail page Bug 14966 fixed a bug but introduced another one: With IndependentBranches set to 'prevent', if the librarian (without the superlibrarian permission) can edit items but not all, the table is broken. DataTables raises the following warning: "DataTables warning: table id=DataTables_Table_1 - Requested unknown parameter '8' for row0." And does not display correctly. Test plan: 1/ Create a biblio record with 1+ items located in different places. 2/ Create/use a patron with the permission to edit items 3/ Set the IndependentBranches pref to 'prevent' 4/ With this patron logged in, go on the record detail page. Without this patch, the display is broken (only 1 edit link and 1 td missing, DataTables raises a warning). With this patch, the display is correct. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> See the warning, and the broken table. Solved by this patch. Created attachment 45207 [details] [review] [PASSED QA] Bug 15256: Fix items table display on the detail page Bug 14966 fixed a bug but introduced another one: With IndependentBranches set to 'prevent', if the librarian (without the superlibrarian permission) can edit items but not all, the table is broken. DataTables raises the following warning: "DataTables warning: table id=DataTables_Table_1 - Requested unknown parameter '8' for row0." And does not display correctly. Test plan: 1/ Create a biblio record with 1+ items located in different places. 2/ Create/use a patron with the permission to edit items 3/ Set the IndependentBranches pref to 'prevent' 4/ With this patron logged in, go on the record detail page. Without this patch, the display is broken (only 1 edit link and 1 td missing, DataTables raises a warning). With this patch, the display is correct. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> See the warning, and the broken table. Solved by this patch. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patch pushed to master. Thanks Jonathan! Patch pushed to 3.22.x, will be in 3.22.1 This patch has been pushed to 3.20.x, will be in 3.20.7. Pushed to 3.18.13, and released. |