Bug 15284

Summary:	Switch default ISSUESLIP notice to Template Toolkit
Product:	Koha	Reporter:	Kyle M Hall (khall) <kyle>
Component:	Notices	Assignee:	Kyle M Hall (khall) <kyle>
Status:	BLOCKED ---	QA Contact:	Testopia <testopia>
Severity:	enhancement
Priority:	P5 - low	CC:	aleisha, black23, dcook, roch.damour
Version:	unspecified
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Bug Depends on:	15283
Bug Blocks:	15278, 1232
Attachments:	Bug 15284 - Switch default ISSUESLIP notice to Template Toolkit Bug 15284: Switch default ISSUESLIP notice to Template Toolkit Bug 15284 - Switch default ISSUESLIP notice to Template Toolkit Bug 15284 - Switch default ISSUESLIP notice to Template Toolkit

Description Kyle M Hall (khall) 2015-12-02 17:18:58 UTC

Comment 1 Kyle M Hall (khall) 2015-12-02 17:36:42 UTC

Created attachment 45337 [details] [review]
Bug 15284 - Switch default ISSUESLIP notice to Template Toolkit

Test Plan:
1) Apply this patch
2) Replace your ISSUESLIP with the following:

[% USE KohaDates %]
<h3>[% branch.branchname %]</h3>
Checked out to [% borrower.title %] [% borrower.firstname %] [% borrower.initials %] [% borrower.surname %] <br />
([% borrower.cardnumber %]) <br />

[% today | $KohaDates %]<br />

<h4>Checked Out</h4>
[% FOREACH checkout IN borrower.checkouts %]
    [% IF ! checkout.is_overdue %]
        <p>
            [% checkout.item.biblio.title %] <br />
            Barcode: [% checkout.item.barcode %]<br />
            Date due: [% checkout.date_due | $KohaDates %]<br />
        </p>
    [% END %]
[% END %]

<h4>Overdues</h4>
[% FOREACH checkout IN borrower.checkouts %]
    [% IF checkout.is_overdue %]
        <p>
            [% checkout.item.biblio.title %] <br />
            Barcode: [% checkout.item.barcode %]<br />
            Date due: [% checkout.date_due | $KohaDates %]<br />
        </p>
    [% END %]
[% END %]

<hr>

<h4 style="text-align: center; font-style:italic;">News</h4>
<news>
<div class="newsitem">
<h5 style="margin-bottom: 1px; margin-top: 1px"><b><<opac_news.title>></b></h5>
<p style="margin-bottom: 1px; margin-top: 1px"><<opac_news.new>></p>
<p class="newsfooter" style="font-size: 8pt; font-style:italic; margin-bottom: 1px; margin-top: 1px">Posted on <<opac_news.timestamp>></p>
<hr />
</div>
</news>

3) Print a slip for a patron, note the data is complete

Comment 2 Aleisha Amohia 2015-12-15 23:48:53 UTC

Applying: Bug 15284 - Switch default ISSUESLIP notice to Template Toolkit
fatal: sha1 information is lacking or useless (installer/data/mysql/de-DE/mandatory/sample_notices.sql).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 15284 - Switch default ISSUESLIP notice to Template Toolkit

Comment 3 Charlotte Cordwell 2018-01-17 04:02:04 UTC

Created attachment 70598 [details] [review]
Bug 15284: Switch default ISSUESLIP notice to Template Toolkit

Updated for english version.

Comment 4 Roch D'Amour 2018-03-16 20:20:35 UTC

I tried to apply the patch, but I got a sha1 error. 

fatal: sha1 information is lacking or useless (installer/data/mysql/de-DE/mandatory/sample_notices.sql).
error: could not build fake ancestor

Comment 5 Michal Denar 2018-09-14 20:39:45 UTC

Please rebase on master:

Patch failed at 0001 Bug 15283 - Switch default ISSUEQSLIP notice to Template Toolkit


Thanks

Mike

Comment 6 Kyle M Hall (khall) 2019-07-19 18:21:55 UTC

Created attachment 91659 [details] [review]
Bug 15284 - Switch default ISSUESLIP notice to Template Toolkit

Test Plan:
1) Apply this patch
2) Replace your ISSUESLIP with the following:

[% USE KohaDates %]
<h3>[% branch.branchname %]</h3>
Checked out to [% borrower.title %] [% borrower.firstname %] [% borrower.initials %] [% borrower.surname %] <br />
([% borrower.cardnumber %]) <br />

[% today | $KohaDates %]<br />

<h4>Checked Out</h4>
[% FOREACH checkout IN borrower.checkouts %]
    [% IF ! checkout.is_overdue %]
        <p>
            [% checkout.item.biblio.title %] <br />
            Barcode: [% checkout.item.barcode %]<br />
            Date due: [% checkout.date_due | $KohaDates %]<br />
        </p>
    [% END %]
[% END %]

<h4>Overdues</h4>
[% FOREACH checkout IN borrower.checkouts %]
    [% IF checkout.is_overdue %]
        <p>
            [% checkout.item.biblio.title %] <br />
            Barcode: [% checkout.item.barcode %]<br />
            Date due: [% checkout.date_due | $KohaDates %]<br />
        </p>
    [% END %]
[% END %]

<hr>

<h4 style="text-align: center; font-style:italic;">News</h4>
<news>
<div class="newsitem">
<h5 style="margin-bottom: 1px; margin-top: 1px"><b><<opac_news.title>></b></h5>
<p style="margin-bottom: 1px; margin-top: 1px"><<opac_news.new>></p>
<p class="newsfooter" style="font-size: 8pt; font-style:italic; margin-bottom: 1px; margin-top: 1px">Posted on <<opac_news.timestamp>></p>
<hr />
</div>
</news>

3) Print a slip for a patron, note the data is complete

Comment 7 Michal Denar 2019-07-19 19:13:52 UTC

Created attachment 91664 [details] [review]
Bug 15284 - Switch default ISSUESLIP notice to Template Toolkit

Test Plan:
1) Apply this patch
2) Replace your ISSUESLIP with the following:

[% USE KohaDates %]
<h3>[% branch.branchname %]</h3>
Checked out to [% borrower.title %] [% borrower.firstname %] [% borrower.initials %] [% borrower.surname %] <br />
([% borrower.cardnumber %]) <br />

[% today | $KohaDates %]<br />

<h4>Checked Out</h4>
[% FOREACH checkout IN borrower.checkouts %]
    [% IF ! checkout.is_overdue %]
        <p>
            [% checkout.item.biblio.title %] <br />
            Barcode: [% checkout.item.barcode %]<br />
            Date due: [% checkout.date_due | $KohaDates %]<br />
        </p>
    [% END %]
[% END %]

<h4>Overdues</h4>
[% FOREACH checkout IN borrower.checkouts %]
    [% IF checkout.is_overdue %]
        <p>
            [% checkout.item.biblio.title %] <br />
            Barcode: [% checkout.item.barcode %]<br />
            Date due: [% checkout.date_due | $KohaDates %]<br />
        </p>
    [% END %]
[% END %]

<hr>

<h4 style="text-align: center; font-style:italic;">News</h4>
<news>
<div class="newsitem">
<h5 style="margin-bottom: 1px; margin-top: 1px"><b><<opac_news.title>></b></h5>
<p style="margin-bottom: 1px; margin-top: 1px"><<opac_news.new>></p>
<p class="newsfooter" style="font-size: 8pt; font-style:italic; margin-bottom: 1px; margin-top: 1px">Posted on <<opac_news.timestamp>></p>
<hr />
</div>
</news>

3) Print a slip for a patron, note the data is complete

Signed-off-by: Michal Denar <black23@gmail.com>

Comment 8 Katrin Fischer 2019-08-19 20:19:21 UTC

Currently blocked by depency needing sign-off.

Comment 9 David Cook 2022-09-02 02:04:26 UTC

I think some of those sample notices might've been updated in error or not properly updated?