Summary: | Use Bootstrap modal for cataloging merge MARC preview | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | brendan, hector.hecaxmmx, jonathan.druart, julian.maurice, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/cataloguing/merge.pl | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | |||
Bug Blocks: | 8290 | ||
Attachments: |
Bug 15314 - Use Bootstrap modal for cataloging merge MARC preview
[SIGNED-OFF]Bug 15314: Use Bootstrap modal for cataloging merge MARC preview Bug 15314: Use Bootstrap modal for cataloging merge MARC preview Bug 15314: Use Bootstrap modal for cataloging merge MARC preview |
Description
Owen Leonard
2015-12-04 23:47:49 UTC
Created attachment 45464 [details] [review] Bug 15314 - Use Bootstrap modal for cataloging merge MARC preview In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the cataloging merge selection page so that the MARC preview is shown in a Boostrap modal. This patch also changes the preview link to be the text "View MARC" so that it is clear what it does. To test: 1. Apply the patch and navigate to Cataloging. 2. Perform a search which will return results from the catalog. 3. Select two records and click the "Merge selected" button to begin the merge process. 4. Test the "View MARC" link for both merge choices and confirm that the correct data is shown each time. Created attachment 45473 [details] [review] [SIGNED-OFF]Bug 15314: Use Bootstrap modal for cataloging merge MARC preview In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the cataloging merge selection page so that the MARC preview is shown in a Boostrap modal. This patch also changes the preview link to be the text "View MARC" so that it is clear what it does. To test: 1. Apply the patch and navigate to Cataloging. 2. Perform a search which will return results from the catalog. 3. Select two records and click the "Merge selected" button to begin the merge process. 4. Test the "View MARC" link for both merge choices and confirm that the correct data is shown each time. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Owen, Shouldn't we apply the same change as what you suggest on bug 15327? (In reply to Jonathan Druart from comment #3) > Shouldn't we apply the same change as what you suggest on bug 15327? There are a few issues which need to be resolved before we can universally use the "viewas=html" paramter for showmarc.pl. I plan to address them in a future patch if you don't mind. Created attachment 45588 [details] [review] Bug 15314: Use Bootstrap modal for cataloging merge MARC preview In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the cataloging merge selection page so that the MARC preview is shown in a Boostrap modal. This patch also changes the preview link to be the text "View MARC" so that it is clear what it does. To test: 1. Apply the patch and navigate to Cataloging. 2. Perform a search which will return results from the catalog. 3. Select two records and click the "Merge selected" button to begin the merge process. 4. Test the "View MARC" link for both merge choices and confirm that the correct data is shown each time. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 46061 [details] [review] Bug 15314: Use Bootstrap modal for cataloging merge MARC preview In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the cataloging merge selection page so that the MARC preview is shown in a Boostrap modal. This patch also changes the preview link to be the text "View MARC" so that it is clear what it does. To test: 1. Apply the patch and navigate to Cataloging. 2. Perform a search which will return results from the catalog. 3. Select two records and click the "Merge selected" button to begin the merge process. 4. Test the "View MARC" link for both merge choices and confirm that the correct data is shown each time. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Pushed to Master - Thanks! Switching severity to 'enhancement' as the patch does not fix any bug |