Bug 15314 - Use Bootstrap modal for cataloging merge MARC preview
Summary: Use Bootstrap modal for cataloging merge MARC preview
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/cataloguing/merge.pl
Keywords:
Depends on:
Blocks: 8290
  Show dependency treegraph
 
Reported: 2015-12-04 23:47 UTC by Owen Leonard
Modified: 2017-06-14 22:05 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15314 - Use Bootstrap modal for cataloging merge MARC preview (4.33 KB, patch)
2015-12-07 16:53 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 15314: Use Bootstrap modal for cataloging merge MARC preview (4.38 KB, patch)
2015-12-07 21:46 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 15314: Use Bootstrap modal for cataloging merge MARC preview (4.43 KB, patch)
2015-12-11 09:55 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15314: Use Bootstrap modal for cataloging merge MARC preview (4.50 KB, patch)
2015-12-30 03:39 UTC, Brendan Gallagher
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2015-12-04 23:47:49 UTC
The "MARC" link on the cataloging merge page should trigger a preview in a Bootstrap modal instead of a Greybox modal.
Comment 1 Owen Leonard 2015-12-07 16:53:38 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2015-12-07 21:46:06 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2015-12-08 10:52:55 UTC
Owen,
Shouldn't we apply the same change as what you suggest on bug 15327?
Comment 4 Owen Leonard 2015-12-10 13:24:36 UTC
(In reply to Jonathan Druart from comment #3)
> Shouldn't we apply the same change as what you suggest on bug 15327?

There are a few issues which need to be resolved before we can universally use the "viewas=html" paramter for showmarc.pl. I plan to address them in a future patch if you don't mind.
Comment 5 Jonathan Druart 2015-12-11 09:55:17 UTC Comment hidden (obsolete)
Comment 6 Brendan Gallagher 2015-12-30 03:39:01 UTC
Created attachment 46061 [details] [review]
Bug 15314: Use Bootstrap modal for cataloging merge MARC preview

In order to reduce the number of dependencies for common interactions we
should attempt to use Bootstrap modals in place of Greybox ones.

This patch modifies the cataloging merge selection page so that the
MARC preview is shown in a Boostrap modal. This patch also changes the
preview link to be the text "View MARC" so that it is clear what it
does.

To test:

1. Apply the patch and navigate to Cataloging.
2. Perform a search which will return results from the catalog.
3. Select two records and click the "Merge selected" button to begin the
   merge process.
4. Test the "View MARC" link for both merge choices and confirm that the
   correct data is shown each time.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Comment 7 Brendan Gallagher 2015-12-30 03:39:14 UTC
Pushed to Master - Thanks!
Comment 8 Julian Maurice 2015-12-31 08:56:05 UTC
Switching severity to 'enhancement' as the patch does not fix any bug