| Summary: | 245$a visibility constraints not respected in opac-MARCdetail.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Mark Tompsett <mtompset> |
| Component: | OPAC | Assignee: | Mark Tompsett <mtompset> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | f.demians, julian.maurice, kyle |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 11592 | ||
| Attachments: |
Bug 15382: 245$a visibility constraints not respected in opac-MARCdetail.pl
Bug 15382: 245$a visibility constraints not respected in opac-MARCdetail.pl Bug 15382: 245$a visibility constraints not respected in opac-MARCdetail.pl |
||
|
Description
Mark Tompsett
2015-12-15 15:02:07 UTC
This is related to 11592, but not dependent on it. Okay, it is a tiny piece of the larger puzzle. It blocks 11592, but it can be pushed by itself. :) Created attachment 45708 [details] [review] Bug 15382: 245$a visibility constraints not respected in opac-MARCdetail.pl This tiny change determines if the bibliotitle should be set or not in accordance with the 'Advanced constraints' visiblity setting for OPAC. TEST PLAN --------- 1) Find a record detail in OPAC 2) Click 'MARC view' -- 245$a should be visible. 3) In a new tab, log into the staff client 4) Click 'Koha administration' 5) Click 'MARC bibliographic framework' 6) Click 'MARC structure' for the framework of the record displayed in OPAC. 7) Search for tag: 245, and click 'Search' 8) Click 'Subfields' 9) Click 'Edit' beside the a subfield. 10) Click 'Advanced constraints' 11) Uncheck 'OPAC' 12) Click 'Save changes' 13) In the OPAC tab, refresh -- 245$a (Title) will still be visible! 14) Apply this patch 15) In the OPAC tab, refresh -- 245$a (Title) will be hidden. 16) In the staff client, navigate back to 'Advanced constraints' and check 'OPAC' 17) Click 'Save changes' 18) In the OPAC tab, refresh -- 245$a (Title) will be visible again. 19) Run koha qa tools Created attachment 45714 [details] [review] Bug 15382: 245$a visibility constraints not respected in opac-MARCdetail.pl This tiny change determines if the bibliotitle should be set or not in accordance with the 'Advanced constraints' visiblity setting for OPAC. TEST PLAN --------- 1) Find a record detail in OPAC 2) Click 'MARC view' -- 245$a should be visible. 3) In a new tab, log into the staff client 4) Click 'Koha administration' 5) Click 'MARC bibliographic framework' 6) Click 'MARC structure' for the framework of the record displayed in OPAC. 7) Search for tag: 245, and click 'Search' 8) Click 'Subfields' 9) Click 'Edit' beside the a subfield. 10) Click 'Advanced constraints' 11) Uncheck 'OPAC' 12) Click 'Save changes' 13) In the OPAC tab, refresh -- 245$a (Title) will still be visible! 14) Apply this patch 15) In the OPAC tab, refresh -- 245$a (Title) will be hidden. 16) In the staff client, navigate back to 'Advanced constraints' and check 'OPAC' 17) Click 'Save changes' 18) In the OPAC tab, refresh -- 245$a (Title) will be visible again. 19) Run koha qa tools Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Created attachment 45853 [details] [review] Bug 15382: 245$a visibility constraints not respected in opac-MARCdetail.pl This tiny change determines if the bibliotitle should be set or not in accordance with the 'Advanced constraints' visiblity setting for OPAC. TEST PLAN --------- 1) Find a record detail in OPAC 2) Click 'MARC view' -- 245$a should be visible. 3) In a new tab, log into the staff client 4) Click 'Koha administration' 5) Click 'MARC bibliographic framework' 6) Click 'MARC structure' for the framework of the record displayed in OPAC. 7) Search for tag: 245, and click 'Search' 8) Click 'Subfields' 9) Click 'Edit' beside the a subfield. 10) Click 'Advanced constraints' 11) Uncheck 'OPAC' 12) Click 'Save changes' 13) In the OPAC tab, refresh -- 245$a (Title) will still be visible! 14) Apply this patch 15) In the OPAC tab, refresh -- 245$a (Title) will be hidden. 16) In the staff client, navigate back to 'Advanced constraints' and check 'OPAC' 17) Click 'Save changes' 18) In the OPAC tab, refresh -- 245$a (Title) will be visible again. 19) Run koha qa tools Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master, thanks Mark! Patch pushed to 3.22.x, will be in 3.22.2 This patch has been pushed to 3.20.x, will be in 3.20.8. |