Bug 15382 - 245$a visibility constraints not respected in opac-MARCdetail.pl
Summary: 245$a visibility constraints not respected in opac-MARCdetail.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Mark Tompsett
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 11592
  Show dependency treegraph
 
Reported: 2015-12-15 15:02 UTC by Mark Tompsett
Modified: 2017-06-14 22:05 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15382: 245$a visibility constraints not respected in opac-MARCdetail.pl (1.84 KB, patch)
2015-12-15 15:28 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 15382: 245$a visibility constraints not respected in opac-MARCdetail.pl (1.90 KB, patch)
2015-12-15 22:24 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15382: 245$a visibility constraints not respected in opac-MARCdetail.pl (1.95 KB, patch)
2015-12-18 17:56 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Tompsett 2015-12-15 15:02:07 UTC
The template file for opac-MARCdetail.pl uses a bibliotitle parameter, which is set regardless of the 'advanced constraints' settings of 245$a (which is linked to biblio.title see GetMarcFromKohaField). This patch will correct opac-MARCdetail.pl accordingly.
Comment 1 Mark Tompsett 2015-12-15 15:03:07 UTC
This is related to 11592, but not dependent on it.
Comment 2 Mark Tompsett 2015-12-15 15:12:40 UTC
Okay, it is a tiny piece of the larger puzzle. It blocks 11592, but it can be pushed by itself. :)
Comment 3 Mark Tompsett 2015-12-15 15:28:16 UTC Comment hidden (obsolete)
Comment 4 Aleisha Amohia 2015-12-15 22:24:44 UTC Comment hidden (obsolete)
Comment 5 Kyle M Hall 2015-12-18 17:56:41 UTC
Created attachment 45853 [details] [review]
Bug 15382: 245$a visibility constraints not respected in opac-MARCdetail.pl

This tiny change determines if the bibliotitle should be set or not
in accordance with the 'Advanced constraints' visiblity setting for
OPAC.

TEST PLAN
---------
1) Find a record detail in OPAC
2) Click 'MARC view'
   -- 245$a should be visible.
3) In a new tab, log into the staff client
4) Click 'Koha administration'
5) Click 'MARC bibliographic framework'
6) Click 'MARC structure' for the framework of
   the record displayed in OPAC.
7) Search for tag: 245, and click 'Search'
8) Click 'Subfields'
9) Click 'Edit' beside the a subfield.
10) Click 'Advanced constraints'
11) Uncheck 'OPAC'
12) Click 'Save changes'
13) In the OPAC tab, refresh
    -- 245$a (Title) will still be visible!
14) Apply this patch
15) In the OPAC tab, refresh
    -- 245$a (Title) will be hidden.
16) In the staff client, navigate back to
    'Advanced constraints' and check 'OPAC'
17) Click 'Save changes'
18) In the OPAC tab, refresh
    -- 245$a (Title) will be visible again.
19) Run koha qa tools

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Kyle M Hall 2015-12-30 15:41:25 UTC
Pushed to master, thanks Mark!
Comment 7 Julian Maurice 2015-12-31 13:03:33 UTC
Patch pushed to 3.22.x, will be in 3.22.2
Comment 8 Frédéric Demians 2015-12-31 18:32:16 UTC
This patch has been pushed to 3.20.x, will be in 3.20.8.