Summary: | Fix tabs and inconsistent indentation in smart-rules.tt | ||
---|---|---|---|
Product: | Koha | Reporter: | Jesse Weaver <jweaver> |
Component: | Architecture, internals, and plumbing | Assignee: | Jesse Weaver <jweaver> |
Status: | BLOCKED --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | brendan, jonathan.druart, katrin.fischer |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | |||
Bug Blocks: | 16300 | ||
Attachments: |
Bug 15456: Fix tabs and inconsistent indentation in smart-rules.tt
[SIGNED-OFF] Bug 15456: Fix tabs and inconsistent indentation in smart-rules.tt Bug 15456: Fix tabs and inconsistent indentation in smart-rules.tt Bug 15456: Fix tabs and inconsistent indentation in smart-rules.tt [SIGNED-OFF] Bug 15456: Fix tabs and inconsistent indentation in smart-rules.tt |
Description
Jesse Weaver
2015-12-31 19:47:16 UTC
Created attachment 46161 [details] [review] Bug 15456: Fix tabs and inconsistent indentation in smart-rules.tt To verify patch, run `git diff -w HEAD^' and note that the only changes shown are where [% IF %] statements are expanded/unexpanded onto multiple lines to match the prevailing style. Created attachment 46241 [details] [review] [SIGNED-OFF] Bug 15456: Fix tabs and inconsistent indentation in smart-rules.tt To verify patch, run `git diff -w HEAD^' and note that the only changes shown are where [% IF %] statements are expanded/unexpanded onto multiple lines to match the prevailing style. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Looks like refactoring :) No regressions, no koha-qa errors There are patches in the queue waiting for SO and QA. I would prefer to wait before pushing this patch. Created attachment 46453 [details] [review] Bug 15456: Fix tabs and inconsistent indentation in smart-rules.tt To verify patch, run `git diff -w HEAD^' and note that the only changes shown are where [% IF %] statements are expanded/unexpanded onto multiple lines to match the prevailing style. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Looks like refactoring :) No regressions, no koha-qa errors Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> I looked it up with the splitter tool: bug 8367 - needs sign-off bug 15407 - needs sign-off bug 15354 - passed qa bug 9805 - failed qa bug 14695 - failed qa I'd like to wait a bit too - there is currently no new work dependent on the clean-up and it will make it harder for other patches. Didn't apply cleanly - I know because of the moving target that master is. Please rebase. Once it's done - leave me an @later in #koha and I'll jump right on it. Thank you so much for the time and bother of rebasing. Brendan Created attachment 50364 [details] [review] Bug 15456: Fix tabs and inconsistent indentation in smart-rules.tt To verify patch, run `git diff -w HEAD^' and note that the only changes shown are where [% IF %] statements are expanded/unexpanded onto multiple lines to match the prevailing style. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Looks like refactoring :) No regressions, no koha-qa errors Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Putting back to Needs Signoff purely because the underlying template had moved a bit. Created attachment 50417 [details] [review] [SIGNED-OFF] Bug 15456: Fix tabs and inconsistent indentation in smart-rules.tt To verify patch, run `git diff -w HEAD^' and note that the only changes shown are where [% IF %] statements are expanded/unexpanded onto multiple lines to match the prevailing style. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Looks like refactoring :) No regressions, no koha-qa errors Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> There are still a lot of patches visible on splitter that also want to modify this file - will hold off this for a bit. http://splitter.koha-community.org/files - search for smart-rules Moving this outside of the QA queue. |