Summary: | Authority header search is broken | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Templates | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | brendan, julian.maurice |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 15381 | ||
Bug Blocks: | |||
Attachments: |
Bug 15469: Fix authority header search
Bug 15469: Fix authority header search Bug 15469: Fix authority header search Bug 15469: Same fix for the "entire record" tab [PASSED QA] Bug 15469: Fix authority header search [PASSED QA] Bug 15469: Same fix for the "entire record" tab |
Description
Jonathan Druart
2016-01-05 10:49:54 UTC
Created attachment 46248 [details] [review] Bug 15469: Fix authority header search Introduced by bug 15381. The logs contain plenty of "detail.pl: No method value!" and the dropwdown list is not correctly populated (no value for options) Test plan: Go to the authority module and have a look at the auth type codes dropdown list. Without this patch, the values of the options are empty. With this patch, the values are correctly filled. Created attachment 46249 [details] [review] Bug 15469: Fix authority header search Introduced by bug 15381. The logs contain plenty of "detail.pl: No method value!" and the dropwdown list is not correctly populated (no value for options) Test plan: Go to the authority module and have a look at the auth type codes dropdown list. Without this patch, the values of the options are empty. With this patch, the values are correctly filled. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> I confirm this patch silence noise in log file. I was just about to file a new bug for this. I confirm that the patch solves the issue. Created attachment 46344 [details] [review] Bug 15469: Fix authority header search Introduced by bug 15381. The logs contain plenty of "detail.pl: No method value!" and the dropwdown list is not correctly populated (no value for options) Test plan: Go to the authority module and have a look at the auth type codes dropdown list. Without this patch, the values of the options are empty. With this patch, the values are correctly filled. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> I confirm this patch silence noise in log file. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Hm, this is not quite working for me. I see the same with and without the patch: MARC21 installation. Staff > Authorities Switching tabs in the search bar: Search entire record - pull down remains empty All other tabs - pull down is filled Created attachment 46383 [details] [review] Bug 15469: Same fix for the "entire record" tab Almost there - just one small inconsistency - the last tab shows the 'chronological term' preselected, while all others show 'default'. Can you take a quick look if that's an easy fix? (In reply to Katrin Fischer from comment #7) > Almost there - just one small inconsistency - the last tab shows the > 'chronological term' preselected, while all others show 'default'. > Can you take a quick look if that's an easy fix? I have Default preselected for the 4 tabs. Are you sure it comes from this patch? Hm not sure what else it could, but will retest. It looks like you are right - it was wrong before! Created attachment 46468 [details] [review] [PASSED QA] Bug 15469: Fix authority header search Introduced by bug 15381. The logs contain plenty of "detail.pl: No method value!" and the dropwdown list is not correctly populated (no value for options) Test plan: Go to the authority module and have a look at the auth type codes dropdown list. Without this patch, the values of the options are empty. With this patch, the values are correctly filled. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> I confirm this patch silence noise in log file. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 46469 [details] [review] [PASSED QA] Bug 15469: Same fix for the "entire record" tab Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to Master - Should be in the May 2016 release Does not concern stable versions, changing status to RESOLVED |