Bug 15631

Summary: Move the cities related code to Koha::Cities - part 2
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: brendan, chris
Version: MainKeywords: Academy
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 14888    
Bug Blocks:    
Attachments: Bug 15631: Koha::Cities - remove getzipnamecity
Bug 15631: Koha::Cities - remove getidcity and GetCities
Bug 15631: Koha::Cities - remove getidcity and GetCities
Bug 15631: Koha::Cities - remove getzipnamecity
Bug 15631: Koha::Cities - remove getidcity and GetCities

Description Jonathan Druart 2016-01-20 15:48:40 UTC
Bug 14888 has been pushed, but there are still some cities related code in C4::Members:
- getzipnamecity (no used)
- getidcity
Comment 1 Jonathan Druart 2016-01-20 16:02:09 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2016-01-20 16:02:12 UTC Comment hidden (obsolete)
Comment 3 natasha 2016-01-20 22:32:14 UTC Comment hidden (obsolete)
Comment 4 Kyle M Hall 2016-01-29 17:52:28 UTC
Created attachment 47473 [details] [review]
Bug 15631: Koha::Cities - remove getzipnamecity

C4::Members::getzipnamecity was not used and can be remove safely.

Test plan:
  git grep getzipnamecity
should not return any result.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Kyle M Hall 2016-01-29 17:52:35 UTC
Created attachment 47474 [details] [review]
Bug 15631: Koha::Cities - remove getidcity and GetCities

C4::Members::getidcity and C4::Members::GetCities simply retrieved
cities info from the cities table.
The job done in members/memberentry.pl looked really weird and complicated.
Either I have missed something, or this patch can simplify it.

The expected behavior is:
1. Create a new patron => No city selected
2. Edit an existing patron => The borrowers.city value is selected
3. Add a guarantee => The borrowers.city of the guarantor is selected
4. Edit a guarantee => The borrowers.city of the guarantee is selected

Test plan:
Confirm that the expected behaviors are the ones before and after this patch.

Signed-off-by: Natasha <tasham_8@hotmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Brendan Gallagher 2016-02-24 04:07:19 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!