Bug 14888 has been pushed, but there are still some cities related code in C4::Members: - getzipnamecity (no used) - getidcity
Created attachment 47010 [details] [review] Bug 15631: Koha::Cities - remove getzipnamecity C4::Members::getzipnamecity was not used and can be remove safely. Test plan: git grep getzipnamecity should not return any result.
Created attachment 47011 [details] [review] Bug 15631: Koha::Cities - remove getidcity and GetCities C4::Members::getidcity and C4::Members::GetCities simply retrieved cities info from the cities table. The job done in members/memberentry.pl looked really weird and complicated. Either I have missed something, or this patch can simplify it. The expected behavior is: 1. Create a new patron => No city selected 2. Edit an existing patron => The borrowers.city value is selected 3. Add a guarantee => The borrowers.city of the guarantor is selected 4. Edit a guarantee => The borrowers.city of the guarantee is selected Test plan: Confirm that the expected behaviors are the ones before and after this patch.
Created attachment 47062 [details] [review] Bug 15631: Koha::Cities - remove getidcity and GetCities C4::Members::getidcity and C4::Members::GetCities simply retrieved cities info from the cities table. The job done in members/memberentry.pl looked really weird and complicated. Either I have missed something, or this patch can simplify it. The expected behavior is: 1. Create a new patron => No city selected 2. Edit an existing patron => The borrowers.city value is selected 3. Add a guarantee => The borrowers.city of the guarantor is selected 4. Edit a guarantee => The borrowers.city of the guarantee is selected Test plan: Confirm that the expected behaviors are the ones before and after this patch. Signed-off-by: Natasha <tasham_8@hotmail.com>
Created attachment 47473 [details] [review] Bug 15631: Koha::Cities - remove getzipnamecity C4::Members::getzipnamecity was not used and can be remove safely. Test plan: git grep getzipnamecity should not return any result. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 47474 [details] [review] Bug 15631: Koha::Cities - remove getidcity and GetCities C4::Members::getidcity and C4::Members::GetCities simply retrieved cities info from the cities table. The job done in members/memberentry.pl looked really weird and complicated. Either I have missed something, or this patch can simplify it. The expected behavior is: 1. Create a new patron => No city selected 2. Edit an existing patron => The borrowers.city value is selected 3. Add a guarantee => The borrowers.city of the guarantor is selected 4. Edit a guarantee => The borrowers.city of the guarantee is selected Test plan: Confirm that the expected behaviors are the ones before and after this patch. Signed-off-by: Natasha <tasham_8@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to Master - Should be in the May 2016 release. Thanks!