| Summary: | In transit holds do not show as in transit on request.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
| Component: | Hold requests | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | brendan, gmcharlt, gwilliams, jonathan.druart, julian.maurice, veron |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 15645 - In transit holds do not show as in transit on request.pl
Bug 15645 - In transit holds do not show as in transit on request.pl Bug 15645 - In transit holds do not show as in transit on request.pl Bug 15645: Remove the confusing wait var and use found instead Bug 15645: Remove the confusing wait var and use found instead |
||
|
Description
Kyle M Hall (khall)
2016-01-22 16:35:23 UTC
Created attachment 47197 [details] [review] Bug 15645 - In transit holds do not show as in transit on request.pl A hold in transit will simply appear as an unfilled hold! Test Plan: 1) Place a hold for pickup at a different location 2) Capture that hold for a patron 3) Note you do not see the in transit status on request.pl 4) Apply this patch 5) Refresh the page 6) The hold should now show as in transit! Created attachment 47488 [details] [review] Bug 15645 - In transit holds do not show as in transit on request.pl A hold in transit will simply appear as an unfilled hold! Test Plan: 1) Place a hold for pickup at a different location 2) Capture that hold for a patron 3) Note you do not see the in transit status on request.pl 4) Apply this patch 5) Refresh the page 6) The hold should now show as in transit! Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 47502 [details] [review] Bug 15645 - In transit holds do not show as in transit on request.pl A hold in transit will simply appear as an unfilled hold! Test Plan: 1) Place a hold for pickup at a different location 2) Capture that hold for a patron 3) Note you do not see the in transit status on request.pl 4) Apply this patch 5) Refresh the page 6) The hold should now show as in transit! Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> The code in this area (found/wait/transit) is really confusing. When you read it, this patch does not make sense, but the variable names are not correct in the pl/template and finally it fixes the issue! Created attachment 47503 [details] [review] Bug 15645: Remove the confusing wait var and use found instead Kyle, could you have a look at my follow-up please? It seems that it fixes the confusion. Created attachment 47595 [details] [review] Bug 15645: Remove the confusing wait var and use found instead Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> (In reply to Jonathan Druart from comment #6) > Kyle, could you have a look at my follow-up please? > It seems that it fixes the confusion. Looks good! Pushed to Master - Should be in the May 2016 Release. Thanks Following test plan on 3.22.x, at step 3 I see "Item being transferred to ..." in reserve/request.pl table. Does it mean that this patch is not needed in 3.22 ? Does not concern stable versions, status changed to RESOLVED |