Description
Katrin Fischer
2016-01-26 14:00:27 UTC
Created attachment 72540 [details] [review] Bug 15668 - Add columns configuraiton to intranet details page TODO: Make this account for otherholdings too - see bug 16759 To test: 1 - Apply patches 2 - View biblio details in staff client 3 - Should be able to toggle columns 4 - Go to admin columns settings 5 - Change some settings, verify they work 6 - Enable SeparateHoldings 7 - Don't works, Be sad, get motivated, finish the patchset, get a hug from kidclamp Hi Nick, ist this patch testable? (In reply to Katrin Fischer from comment #2) > Hi Nick, > > ist this patch testable? It needs to take separate holdings into account, not testable *** Bug 23288 has been marked as a duplicate of this bug. *** Created attachment 100641 [details] [review] Bug 15668: Add column configuration to the items table in staff detail pages This still doesn't work with the otherholdings table but I rebased, added missing filters and column config yml. Can't seem to figure out why the otherholdings won't work. The console error is: TypeError: b.settings(...)[0].aoColumns[d] is undefined Created attachment 100642 [details] [review] Bug 15668: Add column configuration to the items table in staff detail pages Created attachment 100786 [details] [review] Bug 15668: Add column configuration to the items table in staff detail pages To test: 1 - Apply patches 2 - View biblio details in staff client 3 - Should be able to toggle columns 4 - Go to admin columns settings 5 - Change some settings, verify they work 6 - Enable SeparateHoldings 7 - Go to a record that has holdings from 2 different branches 8 - Change some settings, verify they work. 9 - Check the Other Holdings Tabs, change some settings make sure they work. 10. - Test all the dataTable functions like the search box, columns, export. make sure they on both tabs Created attachment 100787 [details] [review] Bug 15668: Add column configuration to the items table in staff detail pages To test: 1 - Apply patches 2 - View biblio details in staff client 3 - Should be able to toggle columns 4 - Go to admin columns settings 5 - Change some settings, verify they work 6 - Enable SeparateHoldings 7 - Go to a record that has holdings from 2 different branches 8 - Change some settings, verify they work. 9 - Check the Other Holdings Tabs, change some settings make sure they work. 10. - Test all the dataTable functions like the search box, columns, export. make sure they on both tabs Created attachment 100805 [details] [review] Bug 15668: (follow up) add selector to th follow up add a selector to the <th> to ensure we count the table in questions. Should not affect other pages but is needed on detail.tt where there are two tables to configure Created attachment 101816 [details] [review] Bug 15668: Add column configuration to the items table in staff detail pages To test: 1 - Apply patches 2 - View biblio details in staff client 3 - Should be able to toggle columns 4 - Go to admin columns settings 5 - Change some settings, verify they work 6 - Enable SeparateHoldings 7 - Go to a record that has holdings from 2 different branches 8 - Change some settings, verify they work. 9 - Check the Other Holdings Tabs, change some settings make sure they work. 10. - Test all the dataTable functions like the search box, columns, export. make sure they on both tabs Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Created attachment 101817 [details] [review] Bug 15668: (follow up) add selector to th follow up add a selector to the <th> to ensure we count the table in questions. Should not affect other pages but is needed on detail.tt where there are two tables to configure Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Why are you using bKohaColumnsUseNames? Jonathan, Because that what I see was done in opac-detail.tt. Would you recommend that we not use it? (In reply to Lucas Gass from comment #14) > Jonathan, > > Because that what I see was done in opac-detail.tt. Would you recommend that > we not use it? IIRC it should be used when the order of the columns is dynamic, for instance. It would have required less change to not use it in your case. But now it's done, so I don't think it should be a problem. I thought you had a (real) reason to use it :) Created attachment 104165 [details] [review] Bug 15668: Add column configuration to the items table in staff detail pages To test: 1 - Apply patches 2 - View biblio details in staff client 3 - Should be able to toggle columns 4 - Go to admin columns settings 5 - Change some settings, verify they work 6 - Enable SeparateHoldings 7 - Go to a record that has holdings from 2 different branches 8 - Change some settings, verify they work. 9 - Check the Other Holdings Tabs, change some settings make sure they work. 10. - Test all the dataTable functions like the search box, columns, export. make sure they on both tabs Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 104166 [details] [review] Bug 15668: (follow up) add selector to th follow up add a selector to the <th> to ensure we count the table in questions. Should not affect other pages but is needed on detail.tt where there are two tables to configure Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 104167 [details] [review] Bug 15668: (QA follow-up) Fix capitalization Course Reserves Created attachment 104168 [details] [review] Bug 15668: (QA follow-up) Add date accessioned to column configuration The date accessioned column in the items table was not configurable in the columns settings. To test: - Make sure the Date accessioned is shown in the column list on both tables - Make sure that configuring it via Adminitration > Configure columns works as intended Nice work everyone! Pushed to master for 20.05 enhancement not backported to 19.11 |