Summary: | Show card number minimum and maximum in visible hint when adding a patron | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | brendan, f.demians, julian.maurice |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15690 | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 15691 - Show card number minimum and maximum in visible hint when adding a patron
[SIGNED-OFF]Bug 15691: Show card number minimum and maximum in visible hint when adding a patron Bug 15691: Show card number minimum and maximum in visible hint when adding a patron |
Description
Owen Leonard
2016-01-28 13:26:33 UTC
Created attachment 47389 [details] [review] Bug 15691 - Show card number minimum and maximum in visible hint when adding a patron The CardnumberLength system preference defines card number minimum and maximum allowed values when adding a patron. This information is currently hidden in a title attribute on the card number input field. This patch moves the information into a <div class="hint">, matching other fields in the entry form which offer details about entry guidelines. To test, apply the patch and open the new patron entry form. Test for various values of CardnumberLength, and with 'cardnumber' mandatory or not mandatory as defined in BorrowerMandatoryField. Created attachment 47390 [details] [review] [SIGNED-OFF]Bug 15691: Show card number minimum and maximum in visible hint when adding a patron The CardnumberLength system preference defines card number minimum and maximum allowed values when adding a patron. This information is currently hidden in a title attribute on the card number input field. This patch moves the information into a <div class="hint">, matching other fields in the entry form which offer details about entry guidelines. To test, apply the patch and open the new patron entry form. Test for various values of CardnumberLength, and with 'cardnumber' mandatory or not mandatory as defined in BorrowerMandatoryField. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Created attachment 47467 [details] [review] Bug 15691: Show card number minimum and maximum in visible hint when adding a patron The CardnumberLength system preference defines card number minimum and maximum allowed values when adding a patron. This information is currently hidden in a title attribute on the card number input field. This patch moves the information into a <div class="hint">, matching other fields in the entry form which offer details about entry guidelines. To test, apply the patch and open the new patron entry form. Test for various values of CardnumberLength, and with 'cardnumber' mandatory or not mandatory as defined in BorrowerMandatoryField. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to Master - Should be in the May 2016 Release. Thanks! Patch pushed to 3.22.x, will be in 3.22.5 This patch has been pushed to 3.20.x, will be in 3.20.10. |