Bug 15691 - Show card number minimum and maximum in visible hint when adding a patron
Summary: Show card number minimum and maximum in visible hint when adding a patron
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-28 13:26 UTC by Owen Leonard
Modified: 2017-06-14 22:11 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15691 - Show card number minimum and maximum in visible hint when adding a patron (3.93 KB, patch)
2016-01-28 14:00 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 15691: Show card number minimum and maximum in visible hint when adding a patron (3.98 KB, patch)
2016-01-28 14:51 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 15691: Show card number minimum and maximum in visible hint when adding a patron (4.02 KB, patch)
2016-01-29 16:47 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-01-28 13:26:33 UTC
When adding a new patron, the minimum and maximum allowed card number lengths are embedded in a title tag on the input field. This information is essentially hidden from the user unless they happen to hover their mouse over the field.

We already have a <div class="hint"> component to provide information about fields. We should move the information there.
Comment 1 Owen Leonard 2016-01-28 14:00:59 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2016-01-28 14:51:25 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2016-01-29 16:47:33 UTC
Created attachment 47467 [details] [review]
Bug 15691: Show card number minimum and maximum in visible hint when adding a patron

The CardnumberLength system preference defines card number minimum and
maximum allowed values when adding a patron. This information is
currently hidden in a title attribute on the card number input field.

This patch moves the information into a <div class="hint">, matching
other fields in the entry form which offer details about entry
guidelines.

To test, apply the patch and open the new patron entry form. Test for
various values of CardnumberLength, and with 'cardnumber' mandatory or
not mandatory as defined in BorrowerMandatoryField.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Brendan Gallagher 2016-02-23 22:47:30 UTC
Pushed to Master - Should be in the May 2016 Release.  Thanks!
Comment 5 Julian Maurice 2016-03-07 09:21:05 UTC
Patch pushed to 3.22.x, will be in 3.22.5
Comment 6 Frédéric Demians 2016-03-15 08:58:20 UTC
This patch has been pushed to 3.20.x, will be in 3.20.10.