|
Description
Kyle M Hall (khall)
2016-01-29 19:17:04 UTC
Created attachment 47485 [details] [review] Bug 15706: Changing to circulate_remaining_permissions I have only changed this in the includes for the tabs at the top. Dependent on Bug 12051 as that patch adds extra tabs to the top which would need to be changed later To test: 1) Apply Bug 12051 first, then this patch 2) Ensure that Check Out/Check In/Renew tabs still work as they should 3) Check patch for errors or pages I've missed Sponsored-by: Catalyst IT Created attachment 47486 [details] [review] Bug 15706: Changing to circulate_remaining_permissions I have only changed this in the includes for the tabs at the top. Dependent on Bug 12051 as that patch adds extra tabs to the top which would need to be changed later To test: 1) Apply Bug 12051 first, then this patch 2) Ensure that Check Out/Check In/Renew tabs still work as they should 3) Check patch for errors or pages I've missed Signed-off-by: Marc Véron <veron@veron.ch> With a patron without circulate_remaining_permissions, but another subperm of circulate, I get 2 inputs on the mainpage:
Enter patron card number or partial name:
[+]
Enter patron card number or partial name:
And 2 tabs
Search patrons
Search the catalog
Created attachment 47531 [details] [review] Bug 15706: Changing to circulate_remaining_permissions I have only changed this in the includes for the tabs at the top. Dependent on Bug 12051 as that patch adds extra tabs to the top which would need to be changed later To test: 1) Apply Bug 12051 first, then this patch 2) Ensure that Check Out/Check In/Renew tabs still work as they should 3) Check patch for errors or pages I've missed Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 47532 [details] [review] Bug 15706: Forgot to attach the change I made! Created attachment 47596 [details] [review] Bug 15706: Forgot to attach the change I made! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 47786 [details] [review] Bug 15706: Changing to circulate_remaining_permissions I have only changed this in the includes for the tabs at the top. Dependent on Bug 12051 as that patch adds extra tabs to the top which would need to be changed later To test: 1) Apply Bug 12051 first, then this patch 2) Ensure that Check Out/Check In/Renew tabs still work as they should 3) Check patch for errors or pages I've missed Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 47787 [details] [review] Bug 15706: (follow-up) Changing to circulate_remaining_permissions Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the May 2016 Release. Thanks! Created attachment 48728 [details] [review] [3.22] Bug 15706: Changing to circulate_remaining_permissions Patch for 3.22.x Patch pushed to 3.22.x, will be in 3.22.5 This patch doesn't apply properly on 3.20 branch. Since 17 files are affected, I can't take the risk to fix the merging issues. Can the author of the patch propose a version for 3.20? |