Bug 12051 - add renew tab to top on staff client
Summary: add renew tab to top on staff client
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 15706 16933
  Show dependency treegraph
 
Reported: 2014-04-08 22:45 UTC by Nicole C. Engard
Modified: 2017-12-07 22:18 UTC (History)
9 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Large patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12051: Adds a Renew tab to the staff client (29.05 KB, patch)
2016-01-19 03:48 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 12051: Adds a Renew tab to the staff client (29.22 KB, patch)
2016-01-25 19:19 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 12051: Adds a Renew tab to the staff client (23.55 KB, patch)
2016-01-27 21:53 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 12051: Adds a Renew tab to the staff client (20.72 KB, patch)
2016-01-27 22:02 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 12051: Adds a Renew tab to the staff client (21.40 KB, patch)
2016-01-28 20:02 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 12051: Adds a Renew tab to the staff client (21.53 KB, patch)
2016-01-28 21:23 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 12051: Adds a Renew tab to the staff client (15.22 KB, patch)
2016-01-29 10:47 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 12051: Adds a Renew tab to the staff client (15.28 KB, patch)
2016-01-29 19:18 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2014-04-08 22:45:47 UTC
On pages that have the check out and check in tabs on the quick search box at the top, it would be nice to also have a renew tab.
Comment 1 Aleisha Amohia 2016-01-19 03:48:24 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-01-25 19:19:03 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2016-01-25 20:24:45 UTC
I am not sure about adding the same tabs everywhere - it might get a bit crowded up there. Renew doesn't seem to be used very often as it requires you to have the items on hand to scan the barcodes.

Hm, adding Owen for another opinion.
Comment 4 Aleisha Amohia 2016-01-25 22:00:42 UTC
(In reply to Katrin Fischer from comment #3)
> I am not sure about adding the same tabs everywhere - it might get a bit
> crowded up there. Renew doesn't seem to be used very often as it requires
> you to have the items on hand to scan the barcodes.
> 
> Hm, adding Owen for another opinion.

I see what you mean. Perhaps only on the pages where there is also a check-in tab? Since they also need the barcode for that?
Comment 5 Owen Leonard 2016-01-27 14:26:37 UTC
(In reply to Aleisha Amohia from comment #4)

> I see what you mean. Perhaps only on the pages where there is also a
> check-in tab? Since they also need the barcode for that?

I agree with this. I think the presence of the check-in tab is a good indicator that the Renew tab fits.
Comment 6 Katrin Fischer 2016-01-27 14:46:24 UTC
+1 :)
Comment 7 Aleisha Amohia 2016-01-27 21:53:12 UTC Comment hidden (obsolete)
Comment 8 Aleisha Amohia 2016-01-27 22:02:30 UTC Comment hidden (obsolete)
Comment 9 Marc Véron 2016-01-28 08:23:47 UTC
I think there is one more place where the renew tab would make sense:
/cgi-bin/koha/circ/returns.pl

Use case: A patron who wants to return some books and to renew some others at the same time.
Comment 10 Aleisha Amohia 2016-01-28 20:02:54 UTC Comment hidden (obsolete)
Comment 11 Marc Véron 2016-01-28 21:23:00 UTC Comment hidden (obsolete)
Comment 12 Jonathan Druart 2016-01-29 10:47:25 UTC Comment hidden (obsolete)
Comment 13 Jonathan Druart 2016-01-29 10:51:44 UTC
Aleisha,
I have amended your patch to remove files where only 1 line where added/removed.
I have also fixed a 3 vs 2:

+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/suggestions-add-search.inc
@@ -23,10 +23,11 @@
 		</form>
 	</div>
 	[% END %]
+
 			<ul>
             <li><a href="#suggestions_search">Search suggestions</a></li>
             [% IF ( CAN_user_circulate ) %]<li><a onclick="keep_text(0)" href="#circ_search">Check out</a></li>[% END %]
-            [% IF ( CAN_user_catalogue ) %]<li><a onclick="keep_text(1)" href="#catalog_search">Search the catalog</a></li>[% END %]
+            [% IF ( CAN_user_catalogue ) %]<li><a onclick="keep_text(2)" href="#catalog_search">Search the catalog</a></li>[% END %]
             </ul>
 </div>


I was going to pass QA on this patch, but I am wondering if the permission should not be CAN_user_circulate_circulate_remaining_permissions instead of CAN_user_circulate. Indeed the circ/renew.pl script needs only this subperm.
Comment 14 Kyle M Hall 2016-01-29 19:14:40 UTC
> I was going to pass QA on this patch, but I am wondering if the permission
> should not be CAN_user_circulate_circulate_remaining_permissions instead of
> CAN_user_circulate. Indeed the circ/renew.pl script needs only this subperm.

I think the issue at hand is that this is really just repeating an existing bug. For instance, in cat-search.inc, the checkin box is wrapped with [% IF ( CAN_user_circulate ) %] yet a librarian with only CAN_user_circulate_circulate_remaining_permissions should be able to see the box, as checkins only require circulate_remaining_permissions.

I would suggest we leave it the way it is for now for the sake of consistency and file a new bug to fix the issue globally.
Comment 15 Kyle M Hall 2016-01-29 19:18:17 UTC
Created attachment 47476 [details] [review]
Bug 12051: Adds a Renew tab to the staff client

UPDATE: Added to checkin-search.inc to show up on returns.pl

To test:

1) Apply patch
2) Confirm that there is now a Renew tab on the pages where there is also a Check-in tab only
3) Attempt to renew a book using this, confirm it works as expected
4) Check if I have missed any pages

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 16 Kyle M Hall 2016-01-29 19:19:01 UTC
I have filed bug 15706 for the more systemic issue brought up by Jonathan.
Comment 17 Brendan Gallagher 2016-02-23 21:36:06 UTC
Pushed to Master - Should be in the May 2016 Release.  Thanks!