Bug 15726

Summary:	Add columns configuration and export options to circulation and fine rules
Product:	Koha	Reporter:	HB-NEKLS <gwilliams>
Component:	System Administration	Assignee:	Owen Leonard <oleonard>
Status:	CLOSED WONTFIX	QA Contact:	Testopia <testopia>
Severity:	enhancement
Priority:	P5 - low	CC:	gmcharlt, jonathan.druart, lisettepalouse+koha, marjorie.barry-vila
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Bug 15726: Add columns configuration and export options to circulation and fine rules

Description HB-NEKLS 2016-02-03 03:45:39 UTC

The circulation rules table is so big, you have to scroll across two full laptop screens. If you know a column is not being used by any location, it would be nice to be able to control the visibility of the columns through the new columns_settings.pl option.

Comment 1 Lisette Scheer 2019-06-07 15:55:51 UTC

I also think this would be very helpful. We don't use a bunch of the columns at any of our branches. 
Lisette

Comment 2 Jonathan Druart 2019-06-07 22:57:51 UTC

Hi Owen, if you plan to work on this please try to make the changes as succinct as possible (keeping bug 15522 in mind). Thanks! :)

Comment 3 Owen Leonard 2019-06-10 11:50:52 UTC

(In reply to Jonathan Druart from comment #2)

> keeping bug 15522 in mind)

I think bug 15522 should keep my changes in mind :P

Comment 4 Owen Leonard 2019-06-10 12:38:20 UTC Comment hidden (obsolete)

Created attachment 90452 [details] [review]
Bug 15726: Add columns configuration and export options to circulation and fine rules

This patch adds DataTables search, column configuration, and export
options to the circulation and fine rules table. It does not add or
change sorting.

Some changes to admin/smart-rules.pl were necessary to ensure that form
fields removed by hidden columns wouldn't trigger errors because of
empty values.

This patch also makes minor markup corrections to fix HTML validator
errors.

To test, apply the patch and go to Administration -> Circulation and
fine rules.

 - Test all aspects of the circulation and fine rules table: Adding new
   rules, editing rules, cloning rules, deleting rules.
 - Test the new DataTables features: Search, columns configuration, and
   export.
 - Make changes to the table's column configuration in Administration ->
   Configure columns. Confirm that they are correctly applied to the
   table.

Comment 5 Katrin Fischer 2019-08-20 20:18:47 UTC

Hi Owen, I would really like to see this happen. It would make checking and editing so much easier while we work out a new GUI.

1) Could you please remove the 'buttons' from the export?
2) Add a note, remove the column - edit the the rule again - the note is gone :(