Bug 15522 - New interface for revamped circulation rules
Summary: New interface for revamped circulation rules
Status: BLOCKED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on: 15395 18936 15520
Blocks: 15523 18886
  Show dependency treegraph
 
Reported: 2016-01-07 21:54 UTC by Jesse Weaver
Modified: 2018-09-19 17:41 UTC (History)
14 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 15522: Add API for circulation rules (23.45 KB, patch)
2017-10-17 23:00 UTC, Jesse Weaver
Details | Diff | Splinter Review
Bug 15522: Add JS build pipeline (95.20 KB, patch)
2017-10-17 23:00 UTC, Jesse Weaver
Details | Diff | Splinter Review
Bug 15522: Add production JS build mode (4.71 KB, patch)
2017-10-17 23:00 UTC, Jesse Weaver
Details | Diff | Splinter Review
Bug 15522: New interface for updated circulation rules (59.04 KB, patch)
2017-10-17 23:00 UTC, Jesse Weaver
Details | Diff | Splinter Review
Bug 15522: Remove old circulation rules interface (85.27 KB, patch)
2017-10-17 23:00 UTC, Jesse Weaver
Details | Diff | Splinter Review
Bug 15522: Add API for circulation rules (23.12 KB, patch)
2018-01-29 23:30 UTC, Jesse Weaver
Details | Diff | Splinter Review
Bug 15522: Add JS build pipeline (95.20 KB, patch)
2018-01-29 23:30 UTC, Jesse Weaver
Details | Diff | Splinter Review
Bug 15522: Add production JS build mode (4.71 KB, patch)
2018-01-29 23:30 UTC, Jesse Weaver
Details | Diff | Splinter Review
Bug 15522: New interface for updated circulation rules (59.10 KB, patch)
2018-01-29 23:30 UTC, Jesse Weaver
Details | Diff | Splinter Review
Bug 15522: Remove old circulation rules interface (87.32 KB, patch)
2018-01-29 23:30 UTC, Jesse Weaver
Details | Diff | Splinter Review
Bug 15522: Remove old circulation rules interface (86.78 KB, patch)
2018-02-26 19:20 UTC, Jesse Weaver
Details | Diff | Splinter Review
Bug 15522: Remove old circulation rules interface (87.26 KB, patch)
2018-02-26 19:35 UTC, Jesse Weaver
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Weaver 2016-01-07 21:54:18 UTC
This interface would allow editing individual rules for each branch/category/itemtype, and be reorganized to clearly show the specificity order of default rules. 

(See http://wiki.koha-community.org/wiki/Circulation_Rules_Interface_and_Backend_Revamp_RFC#Frontend for more information and a rough mockup.)
Comment 1 Jesse Weaver 2017-10-17 23:00:00 UTC Comment hidden (obsolete)
Comment 2 Jesse Weaver 2017-10-17 23:00:04 UTC Comment hidden (obsolete)
Comment 3 Jesse Weaver 2017-10-17 23:00:07 UTC Comment hidden (obsolete)
Comment 4 Jesse Weaver 2017-10-17 23:00:10 UTC Comment hidden (obsolete)
Comment 5 Jesse Weaver 2017-10-17 23:00:14 UTC Comment hidden (obsolete)
Comment 6 George Williams (NEKLS) 2018-01-09 18:08:33 UTC
Signed off based on video that Jesse put together for me.
Comment 7 Jonathan Druart 2018-01-09 19:00:28 UTC
(In reply to George Williams (NEKLS) from comment #6)
> Signed off based on video that Jesse put together for me.

Well, none of the dependencies apply cleanly, where are the patches ? :)
Comment 8 Jesse Weaver 2018-01-29 23:30:09 UTC
Created attachment 71048 [details] [review]
Bug 15522: Add API for circulation rules

Test plan:
  1) Run t/db_dependent/api/v1/circ_rules.t .
Comment 9 Jesse Weaver 2018-01-29 23:30:13 UTC
Created attachment 71049 [details] [review]
Bug 15522: Add JS build pipeline

This is not directly testable, but can be either used through the
Makefile:

$ make js-build

(This will automatically install all dependencies.)

Or by manually installing yarn:

$ sudo apt install nodejs npm
$ sudo npm install -g yarn
$ yarn install
$ yarn build

(There is also `make js-watch` and `yarn watch`, which automatically
recompile when files are changed.)
Comment 10 Jesse Weaver 2018-01-29 23:30:17 UTC
Created attachment 71050 [details] [review]
Bug 15522: Add production JS build mode

To use, run yarn build (or make js-build) with PRODUCTION=1.
Comment 11 Jesse Weaver 2018-01-29 23:30:23 UTC
Created attachment 71051 [details] [review]
Bug 15522: New interface for updated circulation rules

Test plan:
  1) Make sure all dependencies are applied, and that their DB upgrades
     have been applied.
  2) Build JS (see previous patches for HOWTO).
  3) Load .../cgi-bin/koha/admin/policy.pl .
  4) Try changing an existing rule (one with a textbox or dropdown). Hit
     "Save rules", ensure that your changes are saved.
  5) Until changes are saved, all cells that are changed or affected by
     your changes should be highlighted in yellow.
  6) Same as above, but deleting a rule by hitting the "x" next to it.
  7) Add rows and columns using the "Choose rule..." and "Choose
     category/item type..." dropdowns.
  8) Add rules by clicking the pencil in a currently unset rule cell.
     Ensure changes are saved.
  9) Hit "Cleanup rules"; all redundant rules should be removed. As this
     only removes rules that are the same as the defaults, this should
     not change any effective rules.
 10) Use the filters at the top right ("Circulation", "Holds" and
     "Fines") to filter the kinds of rules that are shown.
 11) Ensure that any desired library can be shown, including (if
     selected) all at the same time.
Comment 12 Jesse Weaver 2018-01-29 23:30:28 UTC Comment hidden (obsolete)
Comment 13 Jonathan Druart 2018-02-26 17:35:23 UTC
Waiting for depending bugs that are not signed off yet.

Jesse, can you provide a remote branch with all the patches applied?
Comment 14 Jesse Weaver 2018-02-26 19:20:57 UTC Comment hidden (obsolete)
Comment 15 Jesse Weaver 2018-02-26 19:35:39 UTC
Created attachment 72242 [details] [review]
Bug 15522: Remove old circulation rules interface
Comment 16 Jesse Weaver 2018-02-26 19:44:12 UTC
(In reply to Jonathan Druart from comment #13)
> Waiting for depending bugs that are not signed off yet.
> 
> Jesse, can you provide a remote branch with all the patches applied?

https://github.com/pianohacker/koha , branch bz15522-withdeps .