Bug 15733

Summary: Audio Alerts issues in master
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: Staff interfaceAssignee: Kyle M Hall (khall) <kyle>
Status: RESOLVED DUPLICATE QA Contact: Testopia <testopia>
Severity: normal    
Priority: P3 CC: gmcharlt, jonathan.druart
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 11431, 13618, 15734    
Bug Blocks:    
Attachments: Bug 15733: Fix audio alerts

Description Nick Clemens (kidclamp) 2016-02-03 19:01:09 UTC
In master there is a JSON error thrown when AudioAlerts are enabled.  When checking in I get:
SyntaxError: JSON.parse: expected property name or '}' at line 1 column 3 of the JSON data

This does not happen in 3.22


Also (in master and 3.22) single quotes audio selector break ability to edit an alert
Comment 1 Jonathan Druart 2016-02-04 08:26:25 UTC
Created attachment 47636 [details] [review]
Bug 15733: Fix audio alerts

Bug 13618 has broken the audio alerts.

Test plan:
Enable the AudioAlerts pref
Check an item in
Without this patch, there is a js error
With this patch applied, the error is gone
Comment 2 Jonathan Druart 2016-02-04 10:21:07 UTC

*** This bug has been marked as a duplicate of bug 15734 ***